New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Create commit guidelines #4275
Conversation
7cba996
to
95b9d0c
Compare
We will probably have more guidelines, so I would rather put them into a subfolder for that?
|
I think it is worth establishing context and goals as in describe how features will have multiple commits and then a PR and (equal) merge commit with summarizing the changes as a whole. |
Missing secondary footer (functionality) like
|
Yes I thought so as well but as long as we don't have additional files (nor a
I agree on the PR side, but I think a new feature should only be a single commit. You might have previous commits that e.g. refactor the code base in the way you need for the feature but these would be covered by our commit guidelines as well... |
95b9d0c
to
2ac51dc
Compare
Having seen the TYPE prefix on commits now I like them. |
Does someone still have something to add to the guidelines? Or something that you think needs to be changed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel you've done a great job! Making decent guides is no easy task, and this one feels pretty good to me :)
2ac51dc
to
d05a961
Compare
@felix91gr all done (I think) :) |
LGTM I left a small feedback on the |
d05a961
to
3f719ac
Compare
Ah okay now I understand. I was thinking you were referring to writing summary with a capital letter :) |
3f719ac
to
8834fbc
Compare
No description provided.