BUILD(cmake): Fix detection of unbundled GSL #6191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Microsoft.GSL exports the Microsoft.GSL::GSL target. If the namespace isn't specified, the detection moves on the else() block, and while it still gets detected by FindMSGSL.cmake, a false warning is emitted saying that the version is less than 3.0.
Krzmbrzl
approved these changes
Aug 18, 2023
|
Thank you for your contribution 👍 |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Krzmbrzl
added a commit
that referenced
this pull request
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft.GSL exports the Microsoft.GSL::GSL target. If the namespace isn't specified, the detection moves on the else() block, and while it still gets detected by FindMSGSL.cmake, a false warning is emitted saying that the version is less than 3.0.
Checks