Backport "Merge PR #6474: BUILD: Use correct type for num locks" to 1.5.x #6475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CRYPTO_num_locks function of OpenSSL returns an int, but we assigned the value to an unsigned int, leading to a compiler warning about a potential sign change. This is no issue on newer systems as apparently OpenSSL has removed these functions at some point and replaced them with a macro that evaluates to a numeric constant (1). However, on older systems such as CentOS 7, this function still seems to exist and there it actually matters that we are using a wrong type. Fixes #6467 (cherry picked from commit c65ebf1)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
masterto1.5.x:Questions ?
Please refer to the Backport tool documentation