Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen): only generate exposed functions #134

Merged
merged 2 commits into from Apr 14, 2020

Conversation

Wodann
Copy link
Collaborator

@Wodann Wodann commented Apr 14, 2020

This also refactors codegen tests to always include symbol generation in
snapshot tests.

fixes issue #133

This change adds the `pub` keyword to functions as it is the expected
way of exposing functions.
@Wodann Wodann requested a review from baszalmstra April 14, 2020 08:45
@Wodann Wodann self-assigned this Apr 14, 2020
@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #134 into master will increase coverage by 2.87%.
The diff coverage is 89.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   78.86%   81.73%   +2.87%     
==========================================
  Files         141      141              
  Lines        8754     9035     +281     
==========================================
+ Hits         6904     7385     +481     
+ Misses       1850     1650     -200     
Impacted Files Coverage Δ
crates/mun/src/main.rs 0.00% <0.00%> (ø)
crates/mun_compiler/src/driver/config.rs 100.00% <ø> (ø)
crates/mun_compiler/src/lib.rs 0.00% <0.00%> (ø)
crates/mun_compiler_daemon/src/lib.rs 0.00% <0.00%> (ø)
crates/mun_syntax/src/syntax_error.rs 66.66% <50.00%> (-6.07%) ⬇️
crates/mun_compiler/src/driver/display_color.rs 72.72% <72.72%> (ø)
crates/mun_compiler/src/diagnostics.rs 92.92% <91.91%> (+66.69%) ⬆️
crates/mun_compiler/src/diagnostics_snippets.rs 91.97% <91.97%> (ø)
crates/mun_compiler/src/driver.rs 78.84% <92.30%> (+8.63%) ⬆️
crates/mun_compiler/src/annotate.rs 94.31% <94.31%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 857fdd5...d124a56. Read the comment docs.

This also refactors codegen tests to always include symbol generation in
snapshot tests.

fixes issue mun-lang#133
@baszalmstra baszalmstra merged commit 39babc4 into mun-lang:master Apr 14, 2020
@Wodann Wodann deleted the fix/issue-133 branch April 14, 2020 12:46
@Wodann Wodann added this to the Mun v0.2 milestone May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants