Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: derive clone for RootedStruct #323



Copy link

Derive Clone for RootedStruct. All types contained in the RootedStruct already properly support rooting so this was trivial.

The Clone::clone function for a RootedStruct clones the references to the struct instead of the contents of the struct. Is that desirable? I think so because to me it would make more sense to have to clone the struct itself in Mun and return a new rooted struct.

@baszalmstra baszalmstra added the type: improvement Improvement or change to an existing feature label Apr 23, 2021
@baszalmstra baszalmstra requested a review from Wodann April 23, 2021 18:06
@baszalmstra baszalmstra self-assigned this Apr 23, 2021
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #323 (1464216) into master (ba3bdd8) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #323      +/-   ##
- Coverage   80.59%   80.59%   -0.01%     
  Files         259      259              
  Lines       15561    15561              
- Hits        12542    12541       -1     
- Misses       3019     3020       +1     
Impacted Files Coverage Δ
crates/mun_runtime/src/ 76.00% <ø> (ø)
crates/mun_memory/tests/diff/ 83.63% <0.00%> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba3bdd8...1464216. Read the comment docs.

@baszalmstra baszalmstra merged commit d2b6c9c into mun-lang:master May 8, 2021
@Wodann Wodann added this to the Mun v0.4.0 milestone Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
type: improvement Improvement or change to an existing feature
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants