Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: link type information at runtime #377

Merged
merged 28 commits into from May 31, 2022

Conversation

Wodann
Copy link
Collaborator

@Wodann Wodann commented May 15, 2022

Closes #268
Closes #145
Closes #168

@Wodann Wodann requested a review from baszalmstra May 30, 2022 04:07
@Wodann Wodann changed the title WIP: refactor: link type information at runtime refactor: link type information at runtime May 30, 2022
@Wodann Wodann marked this pull request as ready for review May 30, 2022 04:07
@Wodann Wodann self-assigned this May 30, 2022
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #377 (db1f643) into main (98bbeb7) will increase coverage by 1.09%.
The diff coverage is 92.65%.

@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
+ Coverage   82.68%   83.78%   +1.09%     
==========================================
  Files         264      273       +9     
  Lines       15236    16192     +956     
==========================================
+ Hits        12598    13566     +968     
+ Misses       2638     2626      -12     
Impacted Files Coverage Δ
crates/mun/src/ops/start.rs 0.00% <0.00%> (ø)
crates/mun_codegen/src/ir/body.rs 81.53% <ø> (ø)
crates/mun_codegen/src/ir/file_group.rs 71.23% <ø> (-0.39%) ⬇️
crates/mun_codegen/src/value/array_value.rs 79.54% <ø> (+11.36%) ⬆️
crates/mun_memory/src/gc.rs 100.00% <ø> (ø)
crates/mun_memory/src/gc/root_ptr.rs 66.66% <0.00%> (ø)
crates/mun_memory/tests/gc/util.rs 100.00% <ø> (+5.00%) ⬆️
crates/mun_runtime/src/reflection.rs 60.00% <45.45%> (+5.28%) ⬆️
crates/mun_runtime/tests/marshalling.rs 96.19% <50.00%> (-2.02%) ⬇️
crates/mun_abi/src/type_info.rs 75.19% <56.25%> (-10.06%) ⬇️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98bbeb7...db1f643. Read the comment docs.

Copy link
Collaborator

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor comments, overall this looks good enough. Lets get this merged!

cpp/include/mun/field_info.h Show resolved Hide resolved
cpp/include/mun/struct_ref.h Outdated Show resolved Hide resolved
cpp/include/mun/struct_ref.h Outdated Show resolved Hide resolved
cpp/include/mun/type_info.h Show resolved Hide resolved
crates/mun_abi/src/function_info.rs Outdated Show resolved Hide resolved
crates/mun_abi/src/function_info.rs Outdated Show resolved Hide resolved
crates/mun_abi/src/lib.rs Outdated Show resolved Hide resolved
@baszalmstra baszalmstra merged commit 8f6c798 into mun-lang:main May 31, 2022
@Wodann Wodann deleted the refactor/type-id branch May 31, 2022 19:10
@Wodann Wodann added this to the Mun v0.4.0 milestone Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace TypeInfo with TypeRef in Runtime FFI Export types from assemblies and store them in the runtime
2 participants