feat: Remove sqlmodel #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thulio
force-pushed
the
feat/remove-sqlmodel
branch
24 times, most recently
from
93d8b02
to
94dcd24
Compare
|
Foda, @thulio !!! Ótima iniciativa 😻 |
thulio
force-pushed
the
feat/remove-sqlmodel
branch
from
94dcd24
to
b0e39cb
Compare
|
Vou quebrar esse PR em partes menores/não relacionadas |
Merged
thulio
force-pushed
the
feat/remove-sqlmodel
branch
2 times, most recently
from
fc8b256
to
7d51243
Compare
thulio
added
enhancement
thulio
force-pushed
the
feat/remove-sqlmodel
branch
2 times, most recently
from
2bbf8a9
to
640382b
Compare
|
|
thulio
force-pushed
the
feat/remove-sqlmodel
branch
from
640382b
to
60b8908
Compare
| for dependency in getattr(task.model, "__depends_on__", []): | ||
| dag.add_edge(dependency.unique_name(), task.model.unique_name()) | ||
| for dependency in task.model.dependencies(): | ||
| dag.add_edge(dependency.fullname, task.model.unique_name()) |
There was a problem hiding this comment.
Por que unique_name() não é mais usado?
There was a problem hiding this comment.
Porque dependency é do tipo Table e não AmoraModel.
Para AmoraModel, unique_name() == __table__.fullname
thulio
force-pushed
the
feat/remove-sqlmodel
branch
from
388cb64
to
0aa97d0
Compare
|
|
||
| @classmethod | ||
| def dependencies(cls) -> Models: | ||
| def dependencies(cls) -> List[Table]: |
There was a problem hiding this comment.
Algum motivo pra essa mudança ?
There was a problem hiding this comment.
O motivo tava no todo comentado:
# todo: Remover necessidade de __depends_on__ inspecionando a query e chegando ao modelo de origem
# tables: List[Table] = source.froms
diogommartins
approved these changes
Oct 21, 2022
|
🚀🚀🚀🚀🚀🚀 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Esse PR faz amora depender apenas da lib sqlachemy, a qual tem suporte nativo para type-hinting