Fix/example models #220
Merged
Fix/example models #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diogommartins
requested review from
thulio,
lemosflavio,
betowxyz and
eduwxyz
betowxyz
previously approved these changes
Oct 24, 2022
lemosflavio
previously approved these changes
Oct 24, 2022
diogommartins
dismissed stale reviews from lemosflavio and betowxyz
via
7870da0
diogommartins
commented
Oct 25, 2022
amora/models.py
Outdated
Comment on lines
177
to
179
| if cls.__model_config__.materialized == MaterializationTypes.ephemeral: | ||
| cte = cls.source() | ||
| return cte.columns |
There was a problem hiding this comment.
Como o resultado de cls.source() não é cacheado, chamadas diferentes vão resultar instancias de Selectables diferentes, fico na dúvida se essa implementação não pode gerar problemas.
There was a problem hiding this comment.
Vou fazer o merge e seguir em frente. Qualquer coisa, podemos voltar nesse ponto antes de gerar uma release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
step_count_by_source.pygroup by clausesummarizetestssummarizefor sourceless ephemeral modelscte_from_dataframefunctionAmoraModel.columnsclassmethodFixes #165