Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP 8.1 deprecation warnings #151

Closed

Conversation

zero2one
Copy link

@zero2one zero2one commented Sep 5, 2022

Fixes #150

Fixed so that the code stays compatible with the composer PHP
requirements:

Added #[\ReturnTypeWillChange] comments to the methods that do not have
the proper return type set.

Better would be to release a new version of the package that supports
^7.4 || ^8.0 and that defines the proper input and output types.

Fixed so that the code stays compatible with the composer PHP
requirements:

Added #[\ReturnTypeWillChange] comments to the methods that do not have
the proper return type set.

Better would be to release a new version of the package that supports
^7.4 || ^8.0 and that defines the proper input and output types.
@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mundschenk-at
Copy link
Owner

Thank you. I am fixing the warnings via #155 instead (the mixed declaration is 8.0-only and I still want to support at least latter 7.x versions for now).

@mundschenk-at mundschenk-at changed the title #150: Fix PHP 8.1 deprecation warnings Fix PHP 8.1 deprecation warnings Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.1 deprecation warning
2 participants