Plugin postfix_mailvolume: calculate separate volume for delivered mails #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tate Only strings are supported by munin's basic state management.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #941
Calculating the real delivered volume is not trivial, since the size of a mail and the delivery attempt are written to separate log lines. Thus we need to collect the size for each queue item and add this size whenever we see a successful delivery event log line.
This is further complicated by the usage of the
tail_openfunction. This forces us to keep a dictionary of recently encountered mail size values, since we will only parse fresh log lines during each run.This would affect the calculated volume value significantly (e.g. on my mailserver it reduces the volume to 35%). Thus we need to discuss, before merging it.