Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force the graph limits in snmp__if_multi when the speed is known #967

Merged
merged 2 commits into from
Oct 29, 2023

Conversation

ls-initiatives
Copy link
Contributor

This makes it much easier to spot busy/idle interfaces, particularly on devices with many interfaces such as stacked switches.

@coveralls
Copy link

coveralls commented Jun 12, 2018

Pull Request Test Coverage Report for Build 6684317595

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.39%

Totals Coverage Status
Change from base Build 6684276746: 0.0%
Covered Lines: 1109
Relevant Lines: 2158

💛 - Coveralls

@ls-initiatives ls-initiatives changed the title Force the graph limits when the speed is known Force the graph limits in snmp__if_multi when the speed is known Jun 12, 2018
@sumpfralle
Copy link
Collaborator

Thank you for taking a look at the plugin!

I am not really sure, that this change would be beneficial for all users.
It would surely be good for ports with a good amount of traffic. But it would blur the information detail for lightly loaded links (and thus could hide relevant details), since all graphs would be zoomed up to the maximum link speed.

Maybe you could implement this change as a configurable option?
Or what do you think?

@ls-initiatives
Copy link
Contributor Author

I see your point.
Here are a few examples from my own switch.
This change makes it plain which ports were "active" that day, and which were not.
It also makes it plain that none of them are saturated.
On the other hand, fluctuations in the small activity get squashed indeed, so I agree that a 2x or maybe 10x increase would not be noticeable.
Not a problem for me but I see how this would be a pain for someone else.

I was thinking of making it logarithmic, but the we'd need to make the "receive" part positive (log does not accept negatives).
I think it would be good, but probably we'd want to make this throughout all the plugins.

if_1163-day
if_722-day
if_744-day

@sumpfralle
Copy link
Collaborator

I was thinking of making it logarithmic, but the we'd need to make the "receive" part positive (log does not accept negatives).

I think, a lot of people grew accustomed to the +/- visualization of network traffic. At least I did :)
I can hardly imagine, that we want to change this.

I think it would be good, but probably we'd want to make this throughout all the plugins.

This makes this change even less probable, I am afraid.

What do you think: how should we proceed?
Do you want to make the enforcement of the upper limit visualization configurable for the snmp__if plugin?
Or maybe just rely on the warning thresholds for reporting intense port usage?

@ls-initiatives
Copy link
Contributor Author

Warnings have been very unreliable on my setup (way too many false alarms), maybe that's my root problem.

Adding an option would be fine by me, but I'll need time to add it.
Would you like to suggest a name for that option, for consistency ?

@sumpfralle
Copy link
Collaborator

Adding an option would be fine by me, but I'll need time to add it.

I would appreciate that!

Would you like to suggest a name for that option, for consistency?

How about graph_fixed_limit? (defaulting to a false value)

This makes it much easier to spot busy/idle interfaces, particularly on devices with many interfaces such as stacked switches.
@steveschnepp steveschnepp merged commit f2aa835 into munin-monitoring:master Oct 29, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants