Handle missing dependencies of plugins during plugin_load_try #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of letting m64py crash with an OSError when the loading of a plugin fails, it should better create an error message but continue working with the remaining plugins. An error can for example look like this: Frontend: ERROR: failed to load plugin /usr/lib/x86_64-linux-gnu/mupen64plus/mupen64plus-video-glide64mk2.so: libpng15.so.15: cannot open shared object file: No such file or directory
gen2brain
added a commit
that referenced
this pull request
Sep 5, 2014
Handle missing dependencies of plugins during plugin_load_try
ghost
deleted the
ghost
mentioned this pull request
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of letting m64py crash with an OSError when the loading of a plugin fails, it should better create an error message but continue working with the remaining plugins.
An error can for example look like this:
Frontend: ERROR: failed to load plugin /usr/lib/x86_64-linux-gnu/mupen64plus/mupen64plus-video-glide64mk2.so: libpng15.so.15: cannot open shared object file: No such file or directory
This is basically a workaround for the crash mentioned in issue #5. But the specific plugin would still be unusable for the user