Fix nosaveoptions #141
Merged
Fix nosaveoptions #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was removed from the core library in commit 0bcfd3cc7. Without this change, running against a recent core raises an exception similar to that filed here: #75
This patch is parallel to commit 0bb63fe6f5a in mupen64plus-ui-console. mupen64plus/mupen64plus-ui-console@0bb63fe I intend to submit patches for removing configuration saving from plugins (mupen64plus-audio-sdl is aleady done). In exchange, the front-ends should save the configuration at the latest safe opportunity, to capture any changes before most chances of crashes, power outages, kill -9, etc. Discussion: mupen64plus/mupen64plus-audio-sdl#26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds additional configuration saving as discussed here:
mupen64plus/mupen64plus-audio-sdl#26
Before that, though, I had to remove the DelaySI option, since that seems to now be gone from the core.
Thanks,
Corey