Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pie chart #14

Closed
wants to merge 3 commits into from
Closed

Add pie chart #14

wants to merge 3 commits into from

Conversation

tenickl
Copy link

@tenickl tenickl commented Sep 13, 2018

Hi, my first pull request, sorry if I missed some etiquette. I would like to use the pie chart in my blazor test application so i figured why not create a pull request for that.

  • Added support for the pie chart to BlazorComponents.

@muqeet-khan
Copy link
Owner

@tenickl Thank You for the PR!

I usually maintain releases with Blazor version updates. I will take a look and merge this soon if it all fits well (I have a few changes in another PR that may effect this). Appreciate your contribution.

@tenickl
Copy link
Author

tenickl commented Sep 16, 2018

Thanks, if I can improve something please don't hesitate to mention it.

@muqeet-khan
Copy link
Owner

@tenickl I appreciate your contribution and apologize for not merging this change. After making the required changes on master, my lack of git knowledge won and I couldn't figure out how to include your changes in the "updated" master. You would probably have needed to rebase, I think. I have added pie chart based on your implementation from my end and made sure to add you to the credits for this release. Hope you don't mind. Thank you again for contributing.

@muqeet-khan muqeet-khan closed this Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants