Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a structured way for handling menu shortcuts #196

Closed
29 tasks done
Tracked by #142
mengdaming opened this issue Dec 7, 2022 · 0 comments · Fixed by #232
Closed
29 tasks done
Tracked by #142

Add a structured way for handling menu shortcuts #196

mengdaming opened this issue Dec 7, 2022 · 0 comments · Fixed by #232
Assignees
@mengdaming
Labels
M Medium refactoring

Comments

@mengdaming
Copy link
Contributor

mengdaming commented Dec 7, 2022 •
edited
Loading

To do list

  • Replace terminal main menu with a structured menu
    • Create a "Menu" type
      • Create "Menu Option" type
        • Add shortcut attribute and accessor
        • Add description attribute and accessor
        • Add enabler function attribute (to turn on/off a shortcut depending on context)
        • Add isEnabled() function
        • Add action function attribute (action(s) triggered on hitting the shortcut)
        • Add run() function
        • Add quit menu attribute associated to the shortcut used for quitting the current menu
        • Add menu option initializer
      • Add menu initializer
      • Add menu title attribute and accessor
      • Add possibility to add menu options to the menu
      • Add possibility to accept a "key press" event and trigger the associated menu option action
      • Add possibility to list the options available in the menu (enabled only)
    • Add mainMenu attribute to terminal
    • Add main menu initializer function
    • Add call to main menu initializer from terminal constructor
    • Refactor terminal's enterMainMenu() so that it uses the new structured menu instead of a switch/case
    • Refactor terminal's listMainMenuOptions() so that it uses the new structured menu
  • Replace terminal role menus (driver/navigator) with a structured menu
    • Add roleMenu attribute to terminal
    • Add role menu initializer function
    • Add call to role menu initializer from terminal constructor
    • Refactor terminal's startAs(role) function so that it uses the new structured menu instead of a switch/case
    • Refactor terminal's listRoleMenuOptions() so that it uses the new structured menu

Parking Lot

  • Refactor printMenuOption() so that it directly takes a menuOption instance as a parameter
  • Extract readKeyboardInput() function that can be used by any menu
This was referenced Dec 7, 2022
Closed
Closed
@mengdaming mengdaming self-assigned this Jan 25, 2023
mengdaming added a commit that referenced this issue Jan 27, 2023
@mengdaming
[#196] Add menu and menu_option types and use them in terminal main menu
92ad372
mengdaming added a commit that referenced this issue Jan 27, 2023
@mengdaming
[#196] Add possibility to enable/disable a menu_option
5d644c7
mengdaming added a commit that referenced this issue Jan 27, 2023
@mengdaming
[#196] Refactor the terminal's main menu function
ccc5c35
mengdaming added a commit that referenced this issue Jan 27, 2023
@mengdaming
[#196] Replace menuOption's enabled attribute with a menuEnabler func…
279a339 
…tion
mengdaming added a commit that referenced this issue Jan 27, 2023
@mengdaming
[#196] Refactor the terminal's role menu function using new menu stru…
5150f84 
…cture
mengdaming added a commit that referenced this issue Jan 28, 2023
@mengdaming
[#196] Extract menu enablers and actions into separate methods
7c32a10
mengdaming added a commit that referenced this issue Jan 30, 2023
@mengdaming
[#196] Add menu and menu_option types and use them in terminal main menu
12ff873
mengdaming added a commit that referenced this issue Jan 30, 2023
@mengdaming
[#196] Add possibility to enable/disable a menu_option
c708f69
mengdaming added a commit that referenced this issue Jan 30, 2023
@mengdaming
[#196] Refactor the terminal's main menu function
8c9133e
mengdaming added a commit that referenced this issue Jan 30, 2023
@mengdaming
[#196] Replace menuOption's enabled attribute with a menuEnabler func…
87e5bac 
…tion
mengdaming added a commit that referenced this issue Jan 30, 2023
@mengdaming
[#196] Refactor the terminal's role menu function using new menu stru…
f8423da 
…cture
mengdaming added a commit that referenced this issue Jan 30, 2023
@mengdaming
[#196] Extract menu enablers and actions into separate methods
a5f4c1b
mengdaming added a commit that referenced this issue Jan 30, 2023
@mengdaming
[#196] Add test cases on cli/menu.matchAndRun()
fe07054
mengdaming added a commit that referenced this issue Jan 30, 2023
@mengdaming
[#196] Simplify cli/terminal test cases on menu actions
bfecf84
mengdaming added a commit that referenced this issue Jan 30, 2023
@mengdaming
[#196] Improve display of menu arrows and horizontal lines
b7a79ab
mengdaming added a commit that referenced this issue Feb 1, 2023
@mengdaming
[#196] Add menu and menu_option types and use them in terminal main menu
83a22b2
mengdaming added a commit that referenced this issue Feb 1, 2023
@mengdaming
[#196] Add possibility to enable/disable a menu_option
a2551e5
mengdaming added a commit that referenced this issue Feb 1, 2023
@mengdaming
[#196] Refactor the terminal's main menu function
1e6762f
mengdaming added a commit that referenced this issue Feb 1, 2023
@mengdaming
[#196] Replace menuOption's enabled attribute with a menuEnabler func…
8626cea 
…tion
mengdaming added a commit that referenced this issue Feb 1, 2023
@mengdaming
[#196] Refactor the terminal's role menu function using new menu stru…
7326d5b 
…cture
mengdaming added a commit that referenced this issue Feb 1, 2023
@mengdaming
[#196] Extract menu enablers and actions into separate methods
8676c00
mengdaming added a commit that referenced this issue Feb 1, 2023
@mengdaming
[#196] Add test cases on cli/menu.matchAndRun()
2561c4f
mengdaming added a commit that referenced this issue Feb 1, 2023
@mengdaming
[#196] Simplify cli/terminal test cases on menu actions
b51ff92
mengdaming added a commit that referenced this issue Feb 1, 2023
@mengdaming
[#196] Improve display of menu arrows and horizontal lines
bdce072
@mengdaming mengdaming mentioned this issue Feb 1, 2023
Merged
6 tasks
@mengdaming mengdaming linked a pull request Feb 1, 2023 that will close this issue
200 perforce vcs #232
Merged
6 tasks
mengdaming added a commit that referenced this issue Feb 1, 2023
@mengdaming
[#196] Add menu and menu_option types and use them in terminal main menu
cb54f1c
mengdaming added a commit that referenced this issue Feb 1, 2023
@mengdaming
[#196] Add possibility to enable/disable a menu_option
74c409d
mengdaming added a commit that referenced this issue Feb 1, 2023
@mengdaming
[#196] Refactor the terminal's main menu function
cdf6069
mengdaming added a commit that referenced this issue Feb 1, 2023
@mengdaming
[#196] Replace menuOption's enabled attribute with a menuEnabler func…
f6332eb 
…tion
mengdaming added a commit that referenced this issue Feb 1, 2023
@mengdaming
[#196] Refactor the terminal's role menu function using new menu stru…
9f25521 
…cture
mengdaming added a commit that referenced this issue Feb 1, 2023
@mengdaming
[#196] Extract menu enablers and actions into separate methods
757893c
mengdaming added a commit that referenced this issue Feb 1, 2023
@mengdaming
[#196] Add test cases on cli/menu.matchAndRun()
740c981
mengdaming added a commit that referenced this issue Feb 1, 2023
@mengdaming
[#196] Simplify cli/terminal test cases on menu actions
db8d9a0
mengdaming added a commit that referenced this issue Feb 1, 2023
@mengdaming
[#196] Improve display of menu arrows and horizontal lines
63d42bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mengdaming mengdaming

Labels
M Medium refactoring
Projects
TCR Enhancements & Bugs Follow Up
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

200 perforce vcs murex/TCR
1 participant
@mengdaming