QuestionFragment, SubjectExtrasFragment: Avoid repeat onLoadFinished(…

…) calls. This seems to be an Android bug. It causes us to do the same work repeatedly.
murraycu · Oct 9, 2014 · 3438f8a · 3438f8a
1 parent 841bac4
commit 3438f8a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/app/src/main/java/com/murrayc/galaxyzoo/app/QuestionFragment.java b/app/src/main/java/com/murrayc/galaxyzoo/app/QuestionFragment.java
@@ -694,6 +694,11 @@ public void onLoadFinished(Loader<Cursor> cursorLoader, Cursor cursor) {
 
         mLoaderFinished = true;
         updateIfReady();
+
+        // Avoid this being called twice (actually multiple times), which seems to be an Android bug:
+        // See http://stackoverflow.com/questions/14719814/onloadfinished-called-twice
+        // and https://code.google.com/p/android/issues/detail?id=63179
+        getLoaderManager().destroyLoader(URL_LOADER);
     }
 
     private void updateIfReady() {

diff --git a/app/src/main/java/com/murrayc/galaxyzoo/app/SubjectExtrasFragment.java b/app/src/main/java/com/murrayc/galaxyzoo/app/SubjectExtrasFragment.java
@@ -263,6 +263,11 @@ public void onLoadFinished(Loader<Cursor> cursorLoader, Cursor cursor) {
 
         mLoaderFinished = true;
         updateIfReady();
+
+        // Avoid this being called twice (actually multiple times), which seems to be an Android bug:
+        // See http://stackoverflow.com/questions/14719814/onloadfinished-called-twice
+        // and https://code.google.com/p/android/issues/detail?id=63179
+        getLoaderManager().destroyLoader(URL_LOADER);
     }
 
     private void updateIfReady() {