Permalink
Browse files

Fix the build with --enable-warnings=fatal.

By not using -Wsuggest-override (with warnings as errors), though it
is wonderfully useful, because googletest doesn't use the override
keyword yet:
google/googletest#533
  • Loading branch information...
1 parent 88b38c9 commit de88060db83471fa669b14bcd9d7dd2cead7bf67 @murraycu committed Sep 23, 2016
Showing with 8 additions and 1 deletion.
  1. +8 −1 configure.ac
View
@@ -37,9 +37,16 @@ AC_SUBST([LIBMURRAYC_TUPLE_UTILS_SO_VERSION], [0:0:0])
#PKG_CHECK_MODULES([PROJECT], [])
AC_LANG([C++])
+
+# We don't use -Wsuggest-override because googletest doesn't use the override
+# keyword yet:
+# https://github.com/google/googletest/issues/533
+# We could have separate warnings flags for the test compilation, but currently
+# the tests are the only
+# things are are built anyway, because this is a header-only library.
MM_ARG_ENABLE_WARNINGS([PROJECT_WXXFLAGS],
[-Wall],
- [-pedantic -Wall -Wextra -Wsuggest-override -Wshadow -Wformat-security -Wno-missing-field-initializers -fsanitize=undefined -ftrapv -DGSEAL_ENABLE],
+ [-pedantic -Wall -Wextra -Wshadow -Wformat-security -Wno-missing-field-initializers -fsanitize=undefined -ftrapv -DGSEAL_ENABLE],
[])

0 comments on commit de88060

Please sign in to comment.