Skip to content

Commit

Permalink
Fix the build with --enable-warnings=fatal.
Browse files Browse the repository at this point in the history
By not using -Wsuggest-override (with warnings as errors), though it
is wonderfully useful, because googletest doesn't use the override
keyword yet:
google/googletest#533
  • Loading branch information
murraycu committed Sep 23, 2016
1 parent 88b38c9 commit de88060
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,16 @@ AC_SUBST([LIBMURRAYC_TUPLE_UTILS_SO_VERSION], [0:0:0])
#PKG_CHECK_MODULES([PROJECT], [])

AC_LANG([C++])

# We don't use -Wsuggest-override because googletest doesn't use the override
# keyword yet:
# https://github.com/google/googletest/issues/533
# We could have separate warnings flags for the test compilation, but currently
# the tests are the only
# things are are built anyway, because this is a header-only library.
MM_ARG_ENABLE_WARNINGS([PROJECT_WXXFLAGS],
[-Wall],
[-pedantic -Wall -Wextra -Wsuggest-override -Wshadow -Wformat-security -Wno-missing-field-initializers -fsanitize=undefined -ftrapv -DGSEAL_ENABLE],
[-pedantic -Wall -Wextra -Wshadow -Wformat-security -Wno-missing-field-initializers -fsanitize=undefined -ftrapv -DGSEAL_ENABLE],
[])


Expand Down

0 comments on commit de88060

Please sign in to comment.