Adding SAI api tests for CRUD operation #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrispsommers
requested changes
Dec 9, 2022
|
Another thought - since these are all "functional tests," should they go under a new directory |
* Run all SAIC tests, not just vnet. * Change name of test script. Co-authored-by: Chris Sommers <chrispsommers@gmail.com>
murthyvijay
added a commit
that referenced
this pull request
Jan 27, 2023
* Adding SAI api tests for CRUD operation (#4) * Adding SAI api tests for CRUD operation * Cleanup import and fix assert statements * Undo gitignore changes * Update .gitignore * Update .gitignore * Skip get and set tests, not implemented yet * Add dependency tests for VNET In Route test * Fixed some dependency tests * Run all SAIC tests, not just vnet. (#5) * Run all SAIC tests, not just vnet. * Change name of test script. Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Chris Sommers <31145757+chrispsommers@users.noreply.github.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com> * Incorporated changes from feedback from community 1. Updated assert statements to remove false pass 2. Added setup and cleanup to ensure tests pass independently 3. Skip get/set tests because feature not available yet in BMv2 4. Inbound route for the ACL test is skipped due to issue sonic-net#233 * remove unneeded files * Incorporated requested changes Logging and dependencies in tests will be implemented in another PR. Implemented the remaining changes requested --------- Co-authored-by: Chris Sommers <31145757+chrispsommers@users.noreply.github.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requesting review of SAI api tests