Adding SAI api tests for CRUD operation #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
murthyvijay
commented
Dec 14, 2022
•
murthyvijay
commented
- Created a sai-api folder for all functional sai-api testing
- Test cases to test, create, and remove of:
- VNET, ENI, ENI mac address
- Inbound/Outbound Routes
- ACL groups
- PA validation entry
- VNET direction lookup entry
- Test cases to test get and set are marked to be skipped in CI/CD as they have not been implemented. These tests will be executed when get and set are implemented
- Minor fixes to execute all newly included test cases
* Adding SAI api tests for CRUD operation * Cleanup import and fix assert statements * Undo gitignore changes * Update .gitignore * Update .gitignore * Skip get and set tests, not implemented yet * Add dependency tests for VNET In Route test * Fixed some dependency tests * Run all SAIC tests, not just vnet. (#5) * Run all SAIC tests, not just vnet. * Change name of test script. Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Chris Sommers <31145757+chrispsommers@users.noreply.github.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com>
Closed
1. Updated assert statements to remove false pass 2. Added setup and cleanup to ensure tests pass independently 3. Skip get/set tests because feature not available yet in BMv2 4. Inbound route for the ACL test is skipped due to issue sonic-net#233
aputriax
requested changes
Jan 24, 2023
test/test-cases/functional/saic/sai-api/test_sai_api_vnet_acl_in.py
Outdated
Show resolved
Hide resolved
test/test-cases/functional/saic/sai-api/test_sai_api_vnet_acl_in.py
Outdated
Show resolved
Hide resolved
test/test-cases/functional/saic/sai-api/test_sai_api_vnet_direction_lookup.py
Outdated
Show resolved
Hide resolved
test/test-cases/functional/saic/sai-api/test_sai_api_vnet_eni.py
Outdated
Show resolved
Hide resolved
test/test-cases/functional/saic/sai-api/test_sai_api_vnet_pa_entry.py
Outdated
Show resolved
Hide resolved
test/test-cases/functional/saic/sai-api/test_sai_api_vnet_eni_addr.py
Outdated
Show resolved
Hide resolved
Logging and dependencies in tests will be implemented in another PR. Implemented the remaining changes requested
murthyvijay
requested review from
aputriax and
andriy-kokhan
and removed request for
aputriax
aputriax
reviewed
Jan 26, 2023
| print("\n======= SAI commands RETURN values create =======") | ||
| pprint(results) | ||
|
|
||
| assert all(results), "SAI_IP_ADDR_FAMILY_IPV4 Create error" |
There was a problem hiding this comment.
@murthyvijay Could you please check all assert messages? I see that the next 3 messages do not correspond to the SAI calls.
|
Per Community Call 1/25/2023 merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.