Merge pull request #4075 from dmitrio95/bugfix/score_browser_single_c…

…lick_crash-2

fix #272995: avoid handling single clicks twice in ScoreBrowser

mscore/scoreBrowser.cpp

@@ -98,7 +98,11 @@ ScoreListWidget* ScoreBrowser::createScoreList()
       if (!_showPreview)
             sl->setSelectionMode(QAbstractItemView::NoSelection);
 
-      connect(sl, SIGNAL(itemClicked(QListWidgetItem*)), this, SLOT(scoreClicked(QListWidgetItem*)), Qt::QueuedConnection);
+      if (!style()->styleHint(QStyle::SH_ItemView_ActivateItemOnSingleClick)) {
+            // Set our handler for item clicks only if Qt
+            // doesn't treat a click as an item activation.
+            connect(sl, SIGNAL(itemClicked(QListWidgetItem*)), this, SLOT(scoreClicked(QListWidgetItem*)), Qt::QueuedConnection);
+            }
       connect(sl, SIGNAL(itemActivated(QListWidgetItem*)), SLOT(setScoreActivated(QListWidgetItem*)));
       scoreLists.append(sl);
       return sl;
@@ -328,12 +332,6 @@ void ScoreBrowser::scoreClicked(QListWidgetItem* current)
       if (!current)
             return;
 
-      if (style()->styleHint(QStyle::SH_ItemView_ActivateItemOnSingleClick)) {
-            // Qt will consider this click an item activation.
-            // Just let it happen.
-            return;
-            }
-
       ScoreItem* item = static_cast<ScoreItem*>(current);
       if (!_showPreview)
             emit scoreActivated(item->info().filePath());