fix #272995: avoid handling single clicks twice in ScoreBrowser #4075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatoly-os
added a commit
that referenced
this pull request
Oct 29, 2018
…lick_crash-2 fix #272995: avoid handling single clicks twice in ScoreBrowser
anatoly-os
added a commit
that referenced
this pull request
Oct 30, 2018
…lick_crash-2 fix #272995: avoid handling single clicks twice in ScoreBrowser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is probably a better version of #3545. Unfortunately after applying that patch
ScoreBrowserin the start center still keeps crashing on selecting some scores though it now happens much more rarely. This patch stops MuseScore from setting that "bad" connection betweenitemClickedsignal andscoreClickedslot at all if single clicks are treated by Qt in its current configuration as an item activation. This should prevent the crash completely — and it seems to do so according to my tests.