Skip to content

Commit

Permalink
fix #309754: Create Time Signature dialogue doesn't need to add speci…
Browse files Browse the repository at this point in the history
…al text whenever the internal value of nominator or denominator is changed

Special texts are useful just because they can be different from the internal values. There's no need of updating them if the internal values are changed, because they are either blank (and are most likely wished to still be blank, because then they won't affect the layout of the internal values for the time signature) or different from the original values (and are most likely wished to still be different, because if not, there's no point of having them).

See more in https://musescore.org/node/308139#comment-1022250.
  • Loading branch information
Harmoniker1 committed Aug 28, 2020
1 parent f4c0004 commit c8d70a9
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions mscore/timedialog.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ void TimeDialog::save()

void TimeDialog::zChanged(int val)
{
zText->setText(QString("%1").arg(val));
Fraction sig(zNominal->value(), denominator());
groups->setSig(sig, Groups::endings(sig), zText->text(), nText->text());
}
Expand All @@ -138,7 +137,6 @@ void TimeDialog::zChanged(int val)

void TimeDialog::nChanged(int /*val*/)
{
nText->setText(QString("%1").arg(denominator()));
Fraction sig(zNominal->value(), denominator());
groups->setSig(sig, Groups::endings(sig), zText->text(), nText->text());
}
Expand Down

0 comments on commit c8d70a9

Please sign in to comment.