Skip to content

Commit

Permalink
Merge pull request #2264 from MarcSabatella/84296-musicxml-chords
Browse files Browse the repository at this point in the history
fix #84296: bad import of certain chord symbols
  • Loading branch information
wschweer committed Oct 27, 2015
2 parents 5f7a57a + 737b4d4 commit fe8f704
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions libmscore/chordlist.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1182,8 +1182,10 @@ QString ParsedChord::fromXml(const QString& rawKind, const QString& rawKindText,
_quality = "augmented";
else if (kind == "half-diminished") {
_quality = "half-diminished";
extension = 7;
extend = true;
if (symbols) {
extension = 7;
extend = true;
}
}
else if (kind == "diminished-seventh") {
_quality = "diminished";
Expand Down Expand Up @@ -1304,7 +1306,7 @@ QString ParsedChord::fromXml(const QString& rawKind, const QString& rawKindText,
_extension = QString("%1").arg(extension);

// validate kindText
if (kindText != "" && kind != "none") {
if (kindText != "" && kind != "none" && kind != "other") {
ParsedChord validate;
validate.parse(kindText, cl, false);
// kindText should parse to produce same kind, no degrees
Expand Down

0 comments on commit fe8f704

Please sign in to comment.