Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU4 Issue] Implode from multiple voices to chords loses courtesy accidentals #14633

Closed
MarcSabatella opened this issue Nov 21, 2022 · 1 comment · Fixed by #16633
Closed

[MU4 Issue] Implode from multiple voices to chords loses courtesy accidentals #14633

MarcSabatella opened this issue Nov 21, 2022 · 1 comment · Fixed by #16633
Assignees
@oktophonie
Labels
community Issues we would like the community to address engraving P2 Priority: Medium UX/interaction
Projects
[MU4 - SCORE_VIEW] [MU4.0 - ENGRAVING]

Comments

@MarcSabatella
Copy link
Contributor

Describe the bug
If you have multiple voices on a staff and use Tools / Implode, courtesy accidents in voices other than 1 get lsot

To Reproduce
Steps to reproduce the behavior:

  1. Score with one staff, C major
  2. Measure one, note input
  3. Enter voice 1 C6, voice 2 A with explicit natural
  4. Select the measure
  5. Tools / Implode
  6. See error: the natural on the A is lost

Expected behavior
All accidentals - including courtesy (user) accidentals, should be retains

Screenshots
image

Platform information

  • OS: Linux

Additional context
Not a regression; same bug in 3.6.2. Also, other note properties like velocity and tuning are not preserved.
@Tantacrul Tantacrul added the P2 Priority: Medium label Nov 23, 2022
@Tantacrul Tantacrul added this to To do in 4.x SHORTLIST via automation Nov 23, 2022
@Tantacrul Tantacrul added the community Issues we would like the community to address label Nov 23, 2022
@Tantacrul Tantacrul added this to To do in [MU4 - SCORE_VIEW] via automation Nov 23, 2022
@Tantacrul Tantacrul added this to To do in [MU4.0 - ENGRAVING] via automation Nov 23, 2022
@Tantacrul

This comment was marked as resolved.

Sign in to view
mikekirin pushed a commit to mikekirin/MuseScore that referenced this issue Mar 2, 2023
Fix musescore#14633: Implode loses courtesy accidentals
d3d064c
@mikekirin mikekirin mentioned this issue Mar 2, 2023
Merged
8 tasks
mikekirin pushed a commit to mikekirin/MuseScore that referenced this issue Mar 2, 2023
Fix musescore#14633: Implode loses accidentals. Swap fix for propper …
5b10026 
…Note

destruction
@cbjeukendrup cbjeukendrup moved this from To do to In progress in 4.x SHORTLIST Mar 7, 2023
RomanPudashkin added a commit that referenced this issue Mar 14, 2023
@RomanPudashkin
Merge pull request #16633 from mikekirin/14633-implode-from-multiple-…
8f2a6e9 
…voices-accidentals

Fix #14633: implode from multiple voices accidentals.
[MU4 - SCORE_VIEW] automation moved this from To do to Done Mar 14, 2023
4.x SHORTLIST automation moved this from In progress to Done Mar 14, 2023
@oktophonie oktophonie removed this from Done in 4.x SHORTLIST Jun 13, 2023
@oktophonie oktophonie moved this from To do to Done in [MU4.0 - ENGRAVING] Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oktophonie oktophonie

Labels
community Issues we would like the community to address engraving P2 Priority: Medium UX/interaction
Projects
[MU4 - SCORE_VIEW]
  
Done
MuseScore 4.1
Status: Done
[MU4.0 - ENGRAVING]
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #14633: implode from multiple voices accidentals. mikekirin/MuseScore
5 participants
@MarcSabatella @oktophonie @Tantacrul @vpereverzev @asattely