Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #14633: implode from multiple voices accidentals. #16633

Conversation

mikekirin
Copy link
Contributor

Resolves: #14633

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@mikekirin mikekirin force-pushed the 14633-implode-from-multiple-voices-accidentals branch from d3d064c to 5b10026 Compare March 2, 2023 22:56
@mikekirin mikekirin changed the title 14633 implode from multiple voices accidentals. Fix #14633 implode from multiple voices accidentals. Mar 2, 2023
@mikekirin mikekirin changed the title Fix #14633 implode from multiple voices accidentals. Fix #14633: implode from multiple voices accidentals. Mar 2, 2023
@oktophonie
Copy link
Contributor

This seems to work well, though the colour of the selected accidentals does not change to reflect their move to voice 1:
image
This remains the case if deselected/reselected, and only corrects itself after a save and reload.

@mikekirin mikekirin force-pushed the 14633-implode-from-multiple-voices-accidentals branch from 5b10026 to 9217063 Compare March 6, 2023 19:51
@mikekirin mikekirin force-pushed the 14633-implode-from-multiple-voices-accidentals branch from 9217063 to efc9a76 Compare March 7, 2023 00:12
@RomanPudashkin RomanPudashkin merged commit 8f2a6e9 into musescore:master Mar 14, 2023
@mikekirin mikekirin deleted the 14633-implode-from-multiple-voices-accidentals branch March 14, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MU4 Issue] Implode from multiple voices to chords loses courtesy accidentals
3 participants