Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Task] Tidy-up two aspects of new "corrupted score" messaging flows for unsaved scores #16360

Closed
bkunda opened this issue Feb 14, 2023 · 3 comments · Fixed by #16361 or #16648
Closed
Assignees
Labels
P2 Priority: Medium

Comments

@bkunda
Copy link

bkunda commented Feb 14, 2023

Task description
This task relates to #16042 and #16151.

Two things are required:

  1. When the user attempts to save to the cloud an unsaved score, which has become corrupt while they were working on it, they should see this dialog:

214262751-22db8ee7-91bb-4dfa-aff1-5390871a4e05

  1. When the user attempts to "Save as" to their computer an unsaved score, which has become corrupt since they created it, they should see this dialog:

Group 14196

"Save anyway" would trigger the operating system's local save dialog.

I hope that's clear!

Thanks 🙂

@bkunda bkunda added the P2 Priority: Medium label Feb 14, 2023
@bkunda bkunda added this to Needs Triage in [MU4.0.2 PATCH-RELEASE] via automation Feb 14, 2023
@bkunda bkunda changed the title [MU4 Task] Tidy-up two aspects of new corrupted score messaging flows [MU4 Task] Tidy-up two aspects of new "corrupted score" messaging flows for unsaved scores Feb 14, 2023
@RomanPudashkin RomanPudashkin moved this from Needs Triage to Needs Testing in [MU4.0.2 PATCH-RELEASE] Feb 14, 2023
[MU4.0.2 PATCH-RELEASE] automation moved this from Needs Testing to Done Feb 16, 2023
RomanPudashkin added a commit that referenced this issue Feb 16, 2023
fixed #16360: Tidy-up two aspects of new "corrupted score" messaging flows for unsaved scores
@RomanPudashkin RomanPudashkin moved this from Done to Needs Porting in [MU4.0.2 PATCH-RELEASE] Feb 16, 2023
@RomanPudashkin RomanPudashkin moved this from Needs Porting to Done in [MU4.0.2 PATCH-RELEASE] Feb 18, 2023
@bkunda
Copy link
Author

bkunda commented Mar 3, 2023

I have just retested this, and can see that there has been a minor mix-up concerning which buttons are shown in two of the corruption dialogs.
Hopefully a simple swap of the button options should fix this 🙂🤞🏻

Basically, the button options in this dialog:

Screenshot 2023-03-03 at 2 45 47 pm

should be shown in this dialog instead:

Screenshot 2023-03-03 at 2 47 02 pm

And vice-versa.

The reasons are:

The first dialog above gets triggered when the user attempts to save a score to their computer that they have already saved before, and which has since become corrupted. They need to see a "revert to last saved" option to return the score to its previously uncorrupted state (as is indicated in the messaging).

The second dialog above gets triggered when the user attempts to save a score for the first time to their computer, which has recently become corrupted, and which has never been saved by the user before. Therefore, showing a "revert to last saved" option makes no sense, because the user has never saved a previous version of the file.

To be clear, the right messaging is currently being shown under the right conditions in the current 4.0.2 build, its just that the button options between these dialogs are the wrong way around 🙂.

Apologies I missed this in earlier testing – which is why it's very good we are doing a further testing round now!

@DmitryArefiev
Copy link
Contributor

Fixed in #16648

[MU4.0.2 PATCH-RELEASE] automation moved this from Needs Testing to Done Mar 6, 2023
RomanPudashkin added a commit that referenced this issue Mar 6, 2023
fixed #16360: Tidy-up two aspects of new "corrupted score" messaging flows for unsaved scores. Part 2
@RomanPudashkin RomanPudashkin moved this from Done to Needs Porting in [MU4.0.2 PATCH-RELEASE] Mar 6, 2023
@RomanPudashkin RomanPudashkin moved this from Needs Porting to Done in [MU4.0.2 PATCH-RELEASE] Mar 6, 2023
@bkunda
Copy link
Author

bkunda commented Mar 7, 2023

🟢 Re-tested in OS: macOS 13.1, Arch.: x86_64, MuseScore version (64-bit): 4.0.2-230651546, revision: github-musescore-musescore-dbe7c6d. FIXED.

@bkunda bkunda moved this from Done to Done - Tested Again in [MU4.0.2 PATCH-RELEASE] Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Priority: Medium
Projects
No open projects
[MU4.0.2 PATCH-RELEASE]
Done - Tested Again
3 participants