-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MU4 Task] Tidy-up two aspects of new "corrupted score" messaging flows for unsaved scores #16360
Comments
fixed #16360: Tidy-up two aspects of new "corrupted score" messaging flows for unsaved scores
I have just retested this, and can see that there has been a minor mix-up concerning which buttons are shown in two of the corruption dialogs. Basically, the button options in this dialog: should be shown in this dialog instead: And vice-versa. The reasons are: The first dialog above gets triggered when the user attempts to save a score to their computer that they have already saved before, and which has since become corrupted. They need to see a "revert to last saved" option to return the score to its previously uncorrupted state (as is indicated in the messaging). The second dialog above gets triggered when the user attempts to save a score for the first time to their computer, which has recently become corrupted, and which has never been saved by the user before. Therefore, showing a "revert to last saved" option makes no sense, because the user has never saved a previous version of the file. To be clear, the right messaging is currently being shown under the right conditions in the current 4.0.2 build, its just that the button options between these dialogs are the wrong way around 🙂. Apologies I missed this in earlier testing – which is why it's very good we are doing a further testing round now! |
Fixed in #16648 |
fixed #16360: Tidy-up two aspects of new "corrupted score" messaging flows for unsaved scores. Part 2
🟢 Re-tested in OS: macOS 13.1, Arch.: x86_64, MuseScore version (64-bit): 4.0.2-230651546, revision: github-musescore-musescore-dbe7c6d. FIXED. |
Task description
This task relates to #16042 and #16151.
Two things are required:
"Save anyway" would trigger the operating system's local save dialog.
I hope that's clear!
Thanks 🙂
The text was updated successfully, but these errors were encountered: