Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refinements checklist for the new Parts/Score interaction feature #19527

Closed
mike-spa opened this issue Sep 26, 2023 · 16 comments · Fixed by #19882 or #20103
Closed

Refinements checklist for the new Parts/Score interaction feature #19527

mike-spa opened this issue Sep 26, 2023 · 16 comments · Fixed by #19882 or #20103
Assignees
Labels
P1 Priority: High

Comments

@mike-spa
Copy link
Contributor

mike-spa commented Sep 26, 2023

Bug description

@cbjeukendrup @bkunda @oktophonie feel free to dump here all the requests (preferably numbered so I can keep track more easily).

@mike-spa mike-spa self-assigned this Sep 26, 2023
@muse-bot muse-bot added the needs review The issue needs review to set priority, fix version or change status etc. label Sep 26, 2023
@mike-spa mike-spa added the P1 Priority: High label Sep 26, 2023
@mike-spa mike-spa removed the needs review The issue needs review to set priority, fix version or change status etc. label Sep 26, 2023
@cbjeukendrup
Copy link
Contributor

cbjeukendrup commented Sep 30, 2023

  • 1. Bug:

    1. Add ottava
    2. Exclude it from parts
    3. Drag a note in a part => the note does not properly follow the mouse. It always stays an octave higher than the mouse. (the laggy-ness is just my computer; that's not the problem.)
    Schermopname.2023-09-24.om.20.59.31.mov
  • 2. Something questionable:

    1. Select a system header clef
    2. Enable "exclude from parts"
    3. Disable "exclude from parts" => Now there is suddenly a new clef in the parts, that is not a system header clef but a real clef change! But that clef change is not in the main score.
    4. Enter some notes before and after the system break in question, via the main score
    5. When I then switched to the part score, MuseScore crashed.

    So the question is: should the "exclude from parts" checkbox be available for system header clefs? And if yes, how should it behave?

  • 3. Crash when creating parts for a score containing no measures nor boxes: see New score and parts interactions #18722 (comment).

@sammik
Copy link
Contributor

sammik commented Oct 1, 2023

  • 4. Unticking "Exclude from parts" on "Title frame" adds extra (title) frame(s).
Exclude-from-parts.mp4
  1. open parts
  2. on score, select title frame
  3. properties tab tick "Exclude from parts"
  4. untick "Exclude..."
  5. see - extra frame(s) added

probably distantly relative to #19476

@sammik
Copy link
Contributor

sammik commented Oct 14, 2023

  • 5. Unlinked elements shouldn't have "Synchronisation dialog" in properties.

Unlinked-dialog

@mike-spa
Copy link
Contributor Author

mike-spa commented Oct 26, 2023

  • 6.
  • Go to a part, click on the title text, deselect the Text linking property.
  • Change the title text to something else, it won't affect the score (good).
  • Change the title in the score -> it will also affect the part (but it shouldn't cause it was desync-ed).

@mike-spa
Copy link
Contributor Author

mike-spa commented Oct 26, 2023

  • 7
  • Enter rehearsal mark.
  • Go to the part, unlink position and appearance, modify them as preferred (for instance, make the font bigger in the part). Changed will not affect the score (good).
  • Go to the part, modify the text itself of the rehearsal mark -> it will also change the size of the mark in the score (it shouldn't).

Now irrelevant as text size has been moved into "Text" property (not appearance)

@mike-spa
Copy link
Contributor Author

mike-spa commented Oct 26, 2023

  • 8.
  • Enter two notes. Enter dynamics on the first note.
  • In the score, drag the dynamic until it snaps to the next note -> The change in anchor note isn't reflected in the part, meaning the dynamic in the part (despite having all properties still linked) is still attached to the first note

@oktophonie
Copy link
Contributor

oktophonie commented Oct 26, 2023

@bkunda
Copy link

bkunda commented Oct 27, 2023

  • 11. Main score position property changes for slurs and ties don't synchronise with the part unless the part is already open See video

@bkunda
Copy link

bkunda commented Oct 27, 2023

  • 12. Auto-place property not synchronising between main score and parts See video

@sammik
Copy link
Contributor

sammik commented Oct 28, 2023

This one is a bit more complicated

a) If section break is added to horizontal frame before creating parts, it is missing in part.

b) If frame is later included into parts, section break is still missing in parts.

c) If section break is added to frame, after parts were created, it is added to next measure in parts.
(Or if section break is added to frame in part, it is in next measure in score and other parts)

hbox-section-break-parts.mp4

@sammik
Copy link
Contributor

sammik commented Nov 2, 2023

@avvvvve
Copy link

avvvvve commented Nov 9, 2023

  1. Scores and parts synchronization: Trigger unsynced color as soon as an element is moved/edited #19981

This is definitely a nice-to-have and not essential for launch.

@avvvvve
Copy link

avvvvve commented Nov 9, 2023

  • 16.
    Tuplet numbers do not change color when unsynced in parts.
  1. Open a part that has tuplets
  2. Click a tuplet number in the score
  3. Reposition it (or simply turn off the "Position" toggle)
  4. See that it does not turn orange.

scorenpart-tuplet-color

Note that tuplet brackets are already changing color correctly:
scorenpart-tuplet-brackets

@avvvvve
Copy link

avvvvve commented Nov 9, 2023

  • 17.

System elements (like tempo markings) sometimes shift when the "Position" toggle is turned off and then back on. They can be reset back to their original position by turning the "Text" toggle off and on again. It doesn't happen in every part, but seems to happen more when there is an element on the neighboring system above it that is close to it.

scorenpart-jumping-tempo.mov

@miiizen
Copy link
Contributor

miiizen commented Nov 10, 2023

Adding to 16 - this is also the case for the text on textlines
Screenshot 2023-11-10 at 16 20 36

@oktophonie
Copy link
Contributor

oktophonie commented Nov 15, 2023

Fixed in #19882: 1-4, 6, 8, 10
Fixed in #20103: 5, 11, 12, 14, 16, 17
(Only no 15 remains unaddressed from this list, but as that's a link to a separate issue we can now close this one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Priority: High
Projects
Status: Done
9 participants