Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finesse engraving for guitar bends #19823

Closed
11 tasks done
bkunda opened this issue Oct 25, 2023 · 1 comment · Fixed by #19832
Closed
11 tasks done

Finesse engraving for guitar bends #19823

bkunda opened this issue Oct 25, 2023 · 1 comment · Fixed by #19832
Assignees
Labels
P1 Priority: High

Comments

@bkunda
Copy link

bkunda commented Oct 25, 2023

This issue contains a checklist of finesse tasks for the most recent guitar bends implementation (#19746).

It will be continuously updated.

To do

  • Improve horizontal spacing for double (and triple)-stop grace note bends to chords See video
  • Adding bends to range selection chord causes extreme multiplication of bends See video
  • Changing note value at the start of a bend should delete the bend See video
  • Vertical arrow for pre-bends on chords collides with tab fingering
Screenshot 2023-10-27 at 11 02 43 am
  • Collision avoidance required for pre-bends and slurs:
Screenshot 2023-10-27 at 11 19 19 am
  • Improve default content scaling for new bends icons in palettes

Current
Screenshot 2023-10-27 at 11 21 51 am

Desired default scaling
Screenshot 2023-10-27 at 11 22 59 am

Proposed interaction constraints

(Not necessarily bugs, but constraints to prevent janky engraving for unplayable circumstances)

  • Allow no more than one grace note bend or pre-bend on a single note See video
  • Disallow slight bends on regular bends
Screenshot 2023-10-27 at 10 20 23 am
  • Disallow pre-bends on regular bend arrival notes
Screenshot 2023-10-27 at 10 21 53 am
  • Disallow pre-bends on main notes preceded by a grace note bend
Screen.Recording.2023-10-27.at.10.23.27.am.mov
  • “Show hold line” not responding
Screen.Recording.2023-11-01.at.1.20.56.pm.mov
@bkunda bkunda added the P1 Priority: High label Oct 25, 2023
@oktophonie
Copy link
Contributor

oktophonie commented Nov 1, 2023

  • Follow slur rules with regard to direction; in case of mixed stem direction, bend should go above. Currently:
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Priority: High
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants