Guitar bends refinements #19832
Merged
Guitar bends refinements #19832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-spa
force-pushed
the
guitarBendsRefinements
branch
from
b09dfa3
to
5dd7443
Compare
mike-spa
force-pushed
the
guitarBendsRefinements
branch
from
05bfa0a
to
4998cb2
Compare
mike-spa
force-pushed
the
guitarBendsRefinements
branch
from
1845fcb
to
498c673
Compare
|
Tested on macOS. Everything in the issue description has indeed been rectified. Only minor quibble is that the default content scaling for my palette elements (even after performing a factory reset and resetting the palette) is showing as 1.25 (on macOS), instead of the prescribed scale values in the issue. As such, elements still appear a bit small. This could perhaps be refined later though (so as to not block merging what is otherwise a superb PR). |
Jojo-Schmitz
reviewed
Nov 3, 2023
| sp->appendActionIcon(ActionIconType::PRE_BEND, "pre-bend"); | ||
| sp->appendActionIcon(ActionIconType::GRACE_NOTE_BEND, "grace-note-bend"); | ||
| sp->appendActionIcon(ActionIconType::SLIGHT_BEND, "slight-bend"); | ||
| sp->appendActionIcon(ActionIconType::STANDARD_BEND, "standard-bend", 1.25); |
There was a problem hiding this comment.
the issue asks for 1.5
Jojo-Schmitz
reviewed
Nov 3, 2023
| sp->appendActionIcon(ActionIconType::GRACE_NOTE_BEND, "grace-note-bend"); | ||
| sp->appendActionIcon(ActionIconType::SLIGHT_BEND, "slight-bend"); | ||
| sp->appendActionIcon(ActionIconType::STANDARD_BEND, "standard-bend", 1.25); | ||
| sp->appendActionIcon(ActionIconType::PRE_BEND, "pre-bend", 1.25); |
There was a problem hiding this comment.
the issue asks for 1.5
RomanPudashkin
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #19823