A trip to Bendsville #19746
Merged
A trip to Bendsville #19746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return false; | ||
| } | ||
|
|
||
| bool Chord::preOrGraceBendSpacingExceptionInTab() const |
There was a problem hiding this comment.
Could you please explain the purpose of this method?
There was a problem hiding this comment.
Normally, grace notes are placed to the left of their main note (like in the normal staff here). In TABs however, because the main note isn't actually plucked when playing these bends, there are cases where the grace note should overlap the main note, which is why I need this spacing exception.
mike-spa
force-pushed
the
guitarBends
branch
5 times, most recently
from
25fd2aa
to
b2953be
Compare
mike-spa
force-pushed
the
guitarBends
branch
2 times, most recently
from
fc30979
to
ba59064
Compare
Introducing new support for guitar bends both in standard notation and in TAB. - Created GuitarBend class - Introduced new palette elements for standard bend, pre-bend, grace note bend, and slight bend. - Created engraving layout for standard notation and TAB. - Introduced the relevant options in the inspector.
|
@RomanPudashkin @mike-spa I'm satisfied that this PR is performing essentially well. |
RomanPudashkin
approved these changes
Oct 25, 2023
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #19612 (the engraving side)
NEW Guitar Bends feature, with support for standard staff and TAB notation.
Bends:
Bend release:
Grace note bends, pre-bends, pre-bends on grace note bends:
Multibends:
Holds:
Bends on chords:
Microtonal bends:
