Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4] Fix #306189: Extend Tremolo palette #10000

Merged
merged 1 commit into from
May 10, 2023

Conversation

Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz commented Dec 7, 2021

to allow for "Divide measured tremolo by [2-4.6]", tremoloDivisiDots[2-4,6], implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either).

Resolves: https://musescore.org/en/node/106081 and https://musescore.org/en/node/306189 as well as a recent discussion in the OpenScore Contributors' Telegram chat and the notation channel on the MuseScore Discord server.

Not sure yet how to deal with MusicXML ex- and import, or whether at all, @lvinken ? For now just the staccato itself is exported in case of those added symbols

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Dec 7, 2021
to allow for "Divide measured tremolo by [2-4.6]", `tremoloDivisiDots[2-4,6]`, implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either).

Backport of musescore#10000
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Dec 7, 2021
to allow for "Divide measured tremolo by [2-4.6]", `tremoloDivisiDots[2-4,6]`, implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either).

Backport of musescore#10000
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Dec 7, 2021
to allow for "Divide measured tremolo by [2-4.6]", `tremoloDivisiDots[2-4,6]`, implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either).

Backport of musescore#10000
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Dec 7, 2021
to allow for "Divide measured tremolo by [2-4.6]", `tremoloDivisiDots[2-4,6]`, implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either).

Backport of musescore#10000
@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Dec 8, 2021

There's an issue with this: if these dots are below the notehead, they are too close to it (or too close to the bottom staff line).

Above they do look OK. 'Normal' staccatos don't have this issue.
See these images:

image image

Ideas how to fix that are more than welcome ;-)

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Dec 8, 2021
to allow for "Divide measured tremolo by [2-4.6]", `tremoloDivisiDots[2-4,6]`, implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either).

Backport of musescore#10000
@cbjeukendrup
Copy link
Contributor

There's an issue with this: if these dots are below the notehead, they are too close to it (or too close to the bottom staff line).

That is because these SMuFL symbols are apparently only meant to be placed above notes. Compare their placement relative to the baseline with the staccato articulation:

articStaccatoAbove articStaccatoBelow tremoloDivisiDots2
Schermafbeelding 2021-12-08 om 20 59 29 Schermafbeelding 2021-12-08 om 21 01 26 Schermafbeelding 2021-12-08 om 21 01 45

@cbjeukendrup
Copy link
Contributor

Of course, if it is really desired to have a "below the staff" version, you can offset the symbol by bbox().height(), but I would expect that SMuFL has a reason to include only the "above" version. @oktophonie What's your opinion?

@oktophonie
Copy link
Contributor

If the SMuFL spec implies they should only go above notes, we should probably respect that.

That said, even symbols which should always go above sometimes need to go below (when applying to a second voice with stems down), though generally these are then mirrored vertically (which would work fine here).

If the aim is to use these symbols as stand-ins for repeated staccatos, I'd prefer to avoid a hack just to make that work - because if we wish to do that, we should instead implement a better solution that a) uses the primary staccato symbol and b) can work with other articulation marks as well.

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Dec 9, 2021

Well, the original requests for these shows them under the notes.

@lvinken
Copy link
Contributor

lvinken commented Dec 12, 2021

With respect to MusicXML, I can't find anything in the current spec related to tremolo division dots. This may not be supported yet. Also, the SMuFL description "Divide measured tremolo by [2-4.6]" suggest the semantics differ from staccato. Exporting as staccato could be incorrect (even though it would be visually similar).

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Dec 12, 2021

OK, thanks, I've removed them from MusicXML export.

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Dec 13, 2021
to allow for "Divide measured tremolo by [2-4.6]", `tremoloDivisiDots[2-4,6]`, implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either).

Backport of musescore#10000
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Dec 13, 2021
to allow for "Divide measured tremolo by [2-4.6]", `tremoloDivisiDots[2-4,6]`, implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either).

Backport of musescore#10000
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Feb 4, 2022
to allow for "Divide measured tremolo by [2-4.6]", `tremoloDivisiDots[2-4,6]`, implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either).

Backport of musescore#10000
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Feb 5, 2022
to allow for "Divide measured tremolo by [2-4.6]", `tremoloDivisiDots[2-4,6]`, implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either).

Backport of musescore#10000
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Feb 7, 2022
to allow for "Divide measured tremolo by [2-4.6]", `tremoloDivisiDots[2-4,6]`, implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either).

Backport of musescore#10000
@Jojo-Schmitz Jojo-Schmitz force-pushed the tremolo-dots branch 2 times, most recently from e689ae4 to 837538c Compare February 11, 2022 16:10
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 12, 2022
to allow for "Divide measured tremolo by [2-4.6]", `tremoloDivisiDots[2-4,6]`, implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either).

Backport of musescore#10000
@cbjeukendrup cbjeukendrup added the strings Affects translatable strings label Sep 26, 2022
@ecstrema
Copy link
Contributor

Good Job on getting all the x000 to 10000 @Jojo-Schmitz

@Jojo-Schmitz Jojo-Schmitz force-pushed the tremolo-dots branch 2 times, most recently from b8fdecc to 7442134 Compare October 29, 2022 13:11
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
to allow for "Divide measured tremolo by [2-4.6]", `tremoloDivisiDots[2-4,6]`, implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either).

Backport of musescore#10000
@cbjeukendrup
Copy link
Contributor

What is the status of this: #10000 (comment) ?

@Jojo-Schmitz
Copy link
Contributor Author

No change as far as I can tell, but let's rebase first

@Jojo-Schmitz Jojo-Schmitz force-pushed the tremolo-dots branch 2 times, most recently from 0c503fc to b3eeaf5 Compare March 14, 2023 12:20
to allow for "Divide measured tremolo by [2-4,6]", `tremoloDivisiDots[2-4,6]`, implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
strings Affects translatable strings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants