-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Qt 6 #10108
Update to Qt 6 #10108
Conversation
Congratulations!! I think that many changes can be merged separately right now, which do not directly depend on Qt6. |
Thanks! |
1689ba3
to
a7a864a
Compare
a18c066
to
8c22ca3
Compare
c9ff844
to
4d34463
Compare
68833b9
to
00ce742
Compare
Quite good news: Qt 6.3 alpha is released and contains a brand new TreeView component. That was one of the big missing things at the QML side! I will install this alpha version and try if the new TreeView component can help us. |
Ok, I experimented with it for a while. It definitely has much potential to be helpful, so that's a relief. But as soon as we start expanding and collapsing rows as in the Preferences dialog, it goes totally crazy. And dragging rows in the Instruments Panel is even worse. Fortunately, it's still alpha software, so there's hope that it will improve... |
f9247b5
to
feb2445
Compare
fa1f8d3
to
525a11a
Compare
7b7fe2f
to
61ec9dd
Compare
which is required for Qt 6.5.0
Default off; requires universal libsndfile binary.
It was deprecated in Qt 6.4. Basically, just need to specify `globalPos`
…members Also remove a workaround for the default font on macOS that is not necessary anymore.
(and some related improvements/simplifications)
Apparently this got stricter in Qt 6.6
It's time to say farewell to this PR; mainly because I want to free up the qt6 branch name prefix in my fork :) |
It's one unnoticeably small step for a user, but technologically doubtlessly a huge leap forward.
Actually this is a strange experience: I've been working on it so long, and then it finally compiles and runs, and what you see is just MuseScore 4 but with some extra bugs. 😅
But eventually we will need it.
In the first instance, this PR is not meant to be merged soon. It is a bit like a "proof of concept", and to gather feedback on what I have been working over the past months. I'll rebase this PR occasionally to fix conflicts.
Some notes:
XML Patterns
module is removed. We depend on it for (Music)XML schema validation. I'm afraid that the only options are either removing the validation, or pulling in another third-party dependency.toString()
, and then comparing the QString with the string literal, but I realized/found out later that other ways might be more efficient, such as comparing the QStringView from the Xml reader to another QStringView created from the string literal, or using the QStringLiteral macro. We might revise that later.QQuickWindow::setGraphicsApi(QSGRendererInterface::OpenGLRhi)
as they suggest produces such bad results that it is not a viable option, so we can't mix QtQuick and QWidget in one dialog anymore. So we'd better rewrite the EditStyle Dialog completely...source
item. Workaround is to wrap the source item into anotherItem
with some padding, and setting that wrapper item as the source.Statistics:
Resolves: #9951
Resolves: https://musescore.org/en/node/323841