Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mu3] fix #327681 illegal repeatsegment crash #10158

Closed
wants to merge 1 commit into from

Conversation

jeetee
Copy link
Contributor

@jeetee jeetee commented Dec 22, 2021

illegal repeatsegment inserted due to a certain open volta, jump and end repeat combination

Resolves: https://musescore.org/en/node/327681

Fixes interpretation order so the end repeat is covered by the open volta if a jump also exists in the same measure.

  • I signed CLA
  • I made sure the code in the PR follows the 3.x coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@jeetee
Copy link
Contributor Author

jeetee commented Dec 22, 2021

I realize you don't really want Mu3 PR's anymore, but this one is the only build system I have currently set up; and for the benefit of PR#9000

@jeetee jeetee closed this Dec 22, 2021
@jeetee
Copy link
Contributor Author

jeetee commented Dec 22, 2021

See #10159 for the Mu4 fix

@Jojo-Schmitz
Copy link
Contributor

Deleted a tad early, too early for a git cherry-pick. Oh well, I will pick that cherry manually then...

@jeetee
Copy link
Contributor Author

jeetee commented Dec 23, 2021

Deleted a tad early, too early for a git cherry-pick. Oh well, I will pick that cherry manually then...

Closed, purposefully not deleted the branch yet ;-)

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Dec 23, 2021

Well, it doesn't show in the list of PRs in GitHub desktop anymore. Anyway, my manual cherry pick works, it is in #9000 now.

It doesn't crash with that sample score anymore, but playback stoppes at the Fine, the 1st round already, never plays the part after it.
Well, my hacky fix did that too... but I'd rather be sure that this is your intention here?

@jeetee
Copy link
Contributor Author

jeetee commented Dec 23, 2021

Yes, both volta's are skipped and the open volta should cover the end repeat, thus skipping it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants