Custom Key Sig editor - accidentals horizontal auto spacing #10454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
reviewed
Feb 8, 2022
src/palette/view/widgets/keyedit.cpp
Outdated
| double spatium2 = gpaletteScore->spatium() * .5; | ||
| int line = int((y + spatium2 * .5) / spatium2); | ||
| double x = a->ipos().x(); | ||
| double _spatium = gpaletteScore->spatium(); |
There was a problem hiding this comment.
remove another space here, after the =
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 8, 2022
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 9, 2022
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 9, 2022
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 9, 2022
sammik
changed the title
sammik
force-pushed
the
custom-key-sig-hspacing
branch
from
f35edf6
to
2e615b0
Compare
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 14, 2022
…re editor - accidentals are shifted to their normal h-positions - if Control is pressed, free placement (like before) Backport of musescore#10454
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 24, 2022
…re editor - accidentals are shifted to their normal h-positions - if Control is pressed, free placement (like before) Backport of musescore#10454
- accidentals are shifted to their normal h-positions - if Control is pressed, free placement (like before)
sammik
force-pushed
the
custom-key-sig-hspacing
branch
from
2e615b0
to
26b0e2a
Compare
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 12, 2022
…re editor - accidentals are shifted to their normal h-positions - if Control is pressed, free placement (like before) Backport of musescore#10454
8 tasks
|
Fixed in #11581. |
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
…re editor - accidentals are shifted to their normal h-positions - if Control is pressed, free placement (like before) Backport of musescore#10454
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: (329084)
When accidental is added, its h-position is shifted to normal position.
If Control is pressed, free placement is enabled (unshifted placement like it was by default before).