Custom keysig - count symbols width

[sammik]

Custom Key Signature - default accidental positions by symbol width, not fixed xstep

Accidentals have various widths (natural is thin, triple flat is fat). If default xstep were fixed, unwanted gaps, or overlays are produced.
Test file - accidentals on default positions (xAlt = 0)
before (xStep = 1.4 sp):

after (xstep depends od symbol width):

other minor tweaks:

• add more transposable symbols (Sharp Sharp, Natural Sharp, Natural Flat)
• replaced QString by std::string on some places
• replaced score()->spatium() / mag() by spatium() (which already has mag calculation included)

• I signed CLA
• I made sure the code in the PR follows the coding rules
• I made sure the code compiles on my machine
• I made sure there are no unnecessary changes in the code
• I made sure the title of the PR reflects the core meaning of the issue you are solving
• I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
• I made sure the commit message title starts with "fix #424242:" if there is a related issue
• I created the test (mtest, vtest, script test) to verify the changes I made

[RomanPudashkin]

Could you please add some unit-tests (only for changes in the engraving module) that will test your fix?

[sammik]

Could you please add some unit-tests (only for changes in the engraving module) that will test your fix?

@RomanPudashkin sorry, I need some guidance here. Or @cbjeukendrup ?
Any hint, or doc, or wiki please?
Thank You!

[RomanPudashkin]

Sorry, I meant vtests. You already have an experience of adding new vtests :)
#10519

Or you can modify some existing vtests and add your case to them

[sammik]

Updated test file to show accidentals in default xposition (xAlt=0).

vtest fail is IMHO good, see
before

after

@oktophonie I think, now You can look at it.

Thanks

[oktophonie]

How does one even create a custom key signature? I can do one via the palettes but then it has the spacing that I specify (according to where I drag the symbols to), not a 'default' spacing.

[sammik]

I updated editor, so now accidentals takes default positions (unless Control ispressed).
@oktophonie are You happy with it now?
Thank You!

key-editor-snap.mp4