fix #29406: next/previous handling of grace notes. #1148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and convert enum DrumsetKi9nd into an enum class in the due course
…chords fix #28401: transpose chords appropriately in parts
…rtermode fix #28706 Hangup in converter mode with MusicXML source
fix 2 compiler warnings
and a better name for it
when changing timesig
for consistency with other "Eighth"
Is the code duplication with awl/utils.cpp really needed?
and adjust test. Some code duplication with smDrumset ?!?
and tests. Some code duplication with gpDrumset ?!?
Clean-up of mscore font
…n-cleanup Selection cleanup
…fixes Small cosmetic changes to mscoreTAB fonts
various translation and spelling issues
|
In fact, I do think it makes sense to skip the second commit. Even though the navigation behavior while in note input mode is a bit odd - "note input cursor" stays on main note, "selected cursor" traverse grace notes - it's useful in that up/down work. I'm going to revert the second commit. Easy enough to add later if we want. |
|
I left the code to skip grace notes in the history as a revert, hope that's OK. |
|
ola, no it's not unfortunately. The PR now contains 33 commits :( |
|
Don't mind me, I need to reopen to see if my git fix worked... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes here only affect chords with grace notes.
The effect is that next/previous chord commands (right/left arrow) will traverse both grace notes before and grace notes after in the way one might expect - left to right for next-chord, right-to-left for previous-chord, without skipping any or getting hung up anywhere.
If you do this in note input mode, the note input cursor remains on the main note. See http://musescore.org/en/node/23418. I'm not sure how much work it would be to get note input mode to work more directly with grace notes, but since it does not work currently, the second commit in this PR actually disables it rather than create the illusion it will work. That is, if you have a grace note selected upon entering note entry, the cursor will start on the parent note, and left/right keys will skip grace notes while in note input mode.
Eventually of course we could enhance note input mode actually work with grace notes. And if we would rather keep the current behavior where navigation within note input still includes grace ntoes even though you can actually enter them, cherry-pick the first commit of this PR only to at least fix navigation.