Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #331007: [MusicXML import] support tie element #11485

Merged

Conversation

lvinken
Copy link
Contributor

@lvinken lvinken commented May 1, 2022

Resolves: https://musescore.org/en/node/331007

Create a tie on MusicXML import when either a tie or a tied element is present.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 1, 2022
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 1, 2022
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 1, 2022
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented May 1, 2022

@lvinken: My backport to 3.x fails an mtest, "testUnterminatedTies" (see here), seems related to this change. any idea how to deal with it?

That test doesn't seem to exist in master, see:

void unnecessaryBarlines() { mxmlImportTestRef("testUnnecessaryBarlines"); }
void unusualDurations() { mxmlIoTestRef("testUnusualDurations"); }

I see, that test isn't in 3.x either, but had been added with #8556 into the 3.6.2_backend_musicxml branch.

@RomanPudashkin RomanPudashkin merged commit e619c84 into musescore:master May 1, 2022
@lvinken
Copy link
Contributor Author

lvinken commented May 2, 2022

It is quite unfortunate that MusicXML import in the backend and the application itself are not in sync ...

@lvinken lvinken deleted the 331007-musicxml-tie-import branch May 2, 2022 05:14
@Jojo-Schmitz
Copy link
Contributor

Yes, it is. And unfortunate that the author of those is no longer around.

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 4, 2022
That test got added via (the port of) musescore#8566, but now fails after the
backport of musescore#11485.
ToDo: check whether the changes for musescore#8566 (Handle hanging ties) still
work and whether/how to amend that test or the code.
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 12, 2022
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 12, 2022
That test got added via (the port of) musescore#8566, but now fails after the
backport of musescore#11485.
ToDo: check whether the changes for musescore#8566 (Handle hanging ties) still
work and whether/how to amend that test or the code.
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
That test got added via (the port of) musescore#8566, but now fails after the
backport of musescore#11485.
ToDo: check whether the changes for musescore#8566 (Handle hanging ties) still
work and whether/how to amend that test or the code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants