Inspector line cleanup #1373
Merged
Inspector line cleanup #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit fixes the actual bug in http://musescore.org/en/node/36446. I didn't change the basic design of greying out STYLED properties, although that could be worth further discussion in http://musescore.org/en/node/36451.
The second commit just does a bit of cleanup on something that has long bugged me - the empty "Text Line" group in the Inspector for text lines (including pedal, ottava, and volta). I didn't remove the source file for that control; I just commented out the places where it was referenced. So if we do ever decide to populate that group (we could have begin / continue / end text styles, for instance), it would be easy enough to add it back.