Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various articulation improvements #17303

Merged
merged 1 commit into from May 8, 2023

Conversation

asattely
Copy link
Contributor

@asattely asattely commented Apr 21, 2023

Resolves: #17072

Articulation engraving improvements

  • Fixed distance between tenuto and staccato when outside of the staff (before, it was 1sp at all times rather than the articulation distance style setting):
    unnamed
  • Added some fake kearning to move the accent and staccato closer to each other, since the bbox of the accent doesn't really indicate where the staccato is in danger of colliding with the accent:
    image
  • In-the-staff articulations won't go below (for downstem) or above (for upstem) the staff:
    image
  • Added a new style setting for stem-side articulation align.
    image
    The articulation can align over the stem, over the center of the note, or the average of those two placements.
  • Added a style setting to align the in-the-staff articulations with the out of the staff ones, if present and on the same side:
    image

Behavior improvements

  • Articulations are now able to be added when a different articulation is selected--MuseScore will add the articulation to the same chord the selected articulation is attached to. This is useful for palette elements, which explicitly select the added item after adding it. Now it is possible to add multiple articulations from the palette without having to reselect the note every time.
  • Adding articulations via the top bar no longer resets styling on all other accidentals on the chord. The exception to this is combined articulations, such as articTenutoStaccato, which are separated out into their constituent parts (i.e. tenuto and staccato) and added without custom styling.
  • If there is a pre-existing articulation on the chord you are adding an accidental to (with either the palette or the top bar), and that pre-existing artic has a manually-set anchor (top chord, top staff, etc), the new articulation will be added using either top chord or bottom chord, to match the direction of the already-added artics. This allows accidentals to be kept together by default. If there are no manually-set anchors, or if there are two manually-anchored articulations on the chord in different directions, the articulation will have default styling applied.

Still to come (In a different PR as it is rather crunchy; see #17640)

  • Articulation anchors having 5 options to choose from is excessive. We will pare that down to three: above, below, and auto, and whether or not that articulation will go inside the staff will be based on the type of articulation it is, which is to say how it already works.

@asattely asattely force-pushed the articulation-combine branch 6 times, most recently from d6ca4b8 to e714513 Compare April 27, 2023 21:38
@asattely asattely changed the title [DRAFT] articulation improvements Various articulation improvements Apr 28, 2023
@asattely asattely marked this pull request as ready for review April 28, 2023 02:49
@asattely asattely force-pushed the articulation-combine branch 2 times, most recently from 22063aa to ef0ddc3 Compare April 30, 2023 18:50
@oktophonie oktophonie added the vtests This PR produces approved changes to vtest results label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vtests This PR produces approved changes to vtest results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Articulation combination coherence
3 participants