Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Articulation is doubled (marcato-staccato) when adding a second note. #18573

Closed
amijaishalev opened this issue Jul 13, 2023 · 6 comments · Fixed by #19547
Closed

Articulation is doubled (marcato-staccato) when adding a second note. #18573

amijaishalev opened this issue Jul 13, 2023 · 6 comments · Fixed by #19547
Assignees
Labels
engraving P2 Priority: Medium regression Regression on a prior release UX/interaction

Comments

@amijaishalev
Copy link

Issue type

Engraving bug

Bug description

MU doubles de articulation (marcato staccato) when adding a second note using Shift +.

Doesn't seem to happen with adding an interval or adding more notes.

Steps to reproduce

  1. new score, add piano
  2. enter note (D)
  3. toggle marcato and staccato on the note
  4. shit+d (add another note) = should show double articulation
  5. delete the upper note = should leave two articulation on one note

Screenshots/Screen recordings

marcato staccato bug.zip

MuseScore Version

4.1 (but had the same issue with previous nightly)

Regression

I don't know

Operating system

macOS 13.4.1 (22F82)

Additional context

No response

@zacjansheski

This comment was marked as outdated.

@zacjansheski zacjansheski self-assigned this Jul 13, 2023
@amijaishalev
Copy link
Author

Try adding marcato staccato with shift+O, shift+S, then Shift+D.
It should do that, then the deleting part.
Adding the note is after adding the articulations.

@zacjansheski

This comment was marked as outdated.

@MarcSabatella
Copy link
Contributor

MarcSabatella commented Jul 13, 2023

I can reproduce although it took a bit of experimentation. Try this:

  1. press N for note input mode
  2. type C
  3. press Esc to leave note input mode
  4. click the marcato & staccato buttons on the toolbar to add the markings
  5. Press Esc to deselect the note
  6. Click the note to reselect it
  7. press Shift+E to add an E to the chord

Now you'll get the doubled marking. The key seems to be steps 5-6. This isn't the only path to that result, but it's one that is reproducible for me.

A possibly related issue can be seen staying in note input mode:

  1. press N for note input mode
  2. click the marcato button
  3. type C to enter a C with marcato applied
  4. press Shift+E to add an E

This results in the original marcato being removed. You can actually get a similar result in normal mode following my first set of steps above but only clicking marcato instead of both marcato & staccato.

The possible relationship here is that in all of these cases, I think somehow we are looking at the toolbar to decide what we should do when really, Shift+letter should probably ignore that and just add the note.

@oktophonie oktophonie added the regression Regression on a prior release label Jul 14, 2023
@oktophonie
Copy link
Contributor

I encountered the second issue here recently and it's very annoying. It happens also outside note input mode, if you are selecting existing notes with articulations and want to add notes to them with Shift+ to make chords. Also it's a regression on 4.0.2.

This may well have been introduced in #17303 or a related PR.

@oktophonie oktophonie added the P2 Priority: Medium label Jul 14, 2023
@oktophonie oktophonie changed the title MU Doubles articulation (marcato-staccato) when adding a second note. Articulation is doubled (marcato-staccato) when adding a second note. Jul 19, 2023
@zacjansheski
Copy link
Contributor

The second bug in @MarcSabatella 's comment is resolved by #19434

The first issue is still present. (Deselect, reselect then add note with articulations on)

video1660287510.mp4

mathesoncalum added a commit to mathesoncalum/MuseScore that referenced this issue Sep 28, 2023
mathesoncalum added a commit to mathesoncalum/MuseScore that referenced this issue Sep 28, 2023
mathesoncalum added a commit to mathesoncalum/MuseScore that referenced this issue Sep 29, 2023
mathesoncalum added a commit to mathesoncalum/MuseScore that referenced this issue Oct 2, 2023
RomanPudashkin added a commit that referenced this issue Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engraving P2 Priority: Medium regression Regression on a prior release UX/interaction
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants