-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #9873: MU does not taken file name from title when saving score #17690
base: master
Are you sure you want to change the base?
Fix #9873: MU does not taken file name from title when saving score #17690
Conversation
ef7064e
to
5ee621d
Compare
I tested #9873 (comment) briefly on Win/Mac and it looks fine, but it also should be reviewed. @cbjeukendrup Can you help with CR please? |
5ee621d
to
94bcd6d
Compare
94bcd6d
to
b84dc56
Compare
@cbjeukendrup Can you review this? :) |
fn = fn.replace('\n', '_'); | ||
fn = fn.simplified(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to call simplified
first, and to remove fn = fn.replace('\n', '_');
. Otherwise, newlines will be converted into _
even if removeSpace
is false
, while it would be much more logical to convert newlines to spaces in that case.
@@ -285,6 +285,9 @@ io::path_t ProjectConfiguration::defaultSavingFilePath(INotationProjectPtr proje | |||
} | |||
|
|||
filename = io::filename(projectPath, false); | |||
if (filename == NotationProject::scoreDefaultTitle()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I'm not a great fan of comparing strings that may have been translated (we've seen this causing trouble a few times in the past). But in this case I don't see a much better solution, and it seems harmless enough.
But I wondered one thing: shouldn't we look at the title specified in score properties first, before we resort to looking in the notation itself?
fa1f8d3
to
525a11a
Compare
Resolves: #9873