-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Gootville vtest #1776
fix Gootville vtest #1776
Conversation
So we are storing Gonville for the musical font but Gootville Text for the text? that's weird. |
No,Gootville.oft and GootvilleTxte.otf are just the filenames, used internally, in the UI they are called Gonville and Gonville Text. |
The testfiles are currently containing reference to Gonville and Gonville Text. |
Your problem is with font names. You are using two different names: "Gonville" and "Gootville" and I don't know - why. My fonts are named "Gootville": |
thank you for your input... |
:D Hold on! |
this and the previous PR #1771 didn't change anything with regards to this. So this problem got to have been lurking since PR #1556, which did the renaming, (PR #1681 and #1577 just changed the font files). None of these 3 older ones ever updated the vtest files, they are still like they were before that renaming. |
Yes, this is the problem. I think we don't get what we store in the file from the same place here. For score font, we store the first attribute from ScoreFont() here, which is also used in the UI. https://github.com/musescore/MuseScore/blob/master/libmscore/sym.cpp#L29 so Gonville for the Gootville font. The name of the font file is irrelevant, since it's the 3rd param in ScoreFont. For musical text font, we store the second field from https://github.com/musescore/MuseScore/blob/master/mscore/editstyle.cpp#L740 so "Gootville Text" while the first one is used in the UI. The second field is also used as font family name. So here again the font filename is irrelevant but the font family in the file will make it work or not. To sum it up, we are storing "Gootville Text" since https://github.com/musescore/MuseScore/pull/1556/files#diff-855615c9d487c6597383aed2fe12420cR740. I will annotate the code so we know all this for next time... |
No description provided.