fix #39351: alignment of small upstem slash notes #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasconic
added a commit
that referenced
this pull request
Feb 19, 2015
fix #39351: alignment of small upstem slash notes
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was caused by my previous PR #1289, which fixed one problem but introduced another. In hindsight, it wasn't the right way to fix the problem. So this PR reverts that change - which in itself fixes the issue here - and provides a better solution for the previous issue http://musescore.org/en/node/32611. Actually, there were a number of other minor alignment issues with oversize notes (including whole notes and slash notes), both before and after that original fix. My new code here fixes those and should be better all around. It mostly just affects the centering / alignment of oversized (whole notes, slash heads) upstem notes that are set to small, but does so in a much more transparent / straightforward / reasonably well-documented way.