Fix trill cue note bugs #18438
Merged
Fix trill cue note bugs #18438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-spa
force-pushed
the
fixTrillCueNoteBugs
branch
2 times, most recently
from
92df9d4
to
c786c8b
Compare
oktophonie
approved these changes
Jul 7, 2023
| EngravingItem* startItem = item->trill()->startElement(); | ||
| Chord* startChord = startItem && startItem->isChord() ? toChord(startItem) : nullptr; | ||
| if (startChord) { | ||
| item->setStaffIdx(startChord->vStaffIdx()); |
There was a problem hiding this comment.
Please explain why you change the index here
There was a problem hiding this comment.
Because it needs to follow the staffMove of the chord but, unlike chords, spanner items don't have the staffMove property (i.e. the property of belonging to one staff but displaying in another for cross-staff notation), so the only option is to change the staffIdx itself. It's a slight hack, but I think it's the least-bad option (also cause I don't like staffMove in general). I'll put in a comment
mike-spa
force-pushed
the
fixTrillCueNoteBugs
branch
from
c786c8b
to
aa8116c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #18331
Bug 1. Solved -> Trill cue note follows staff move of main note
Bug 3. Solved -> The trill-line should behave consistently with the trill-without-line, meaning it should be deleted when the note is deleted.
Bug 2. Automatically solved by solving bug 3 because creating a tuplet on a note actually causes that note to be deleted (along with all articulations, ornaments etc). We may wish to change this in future but, in that case, that's a separate issue.