Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transpose tool will only transpose initial key signature … #18530

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

miiizen
Copy link
Contributor

@miiizen miiizen commented Jul 11, 2023

…on a system if there is a key

If the first key signature on a system is a change to the measure before, it will be transposed. Otherwise it will be left untouched.

Resolves: #18404

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@cbjeukendrup

This comment was marked as resolved.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Oct 13, 2023
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Oct 15, 2023
@miiizen miiizen force-pushed the 18404-transpose-key-sig branch 2 times, most recently from 165d29c to 3a56014 Compare October 17, 2023 08:45
@@ -156,6 +157,15 @@ bool KeySig::isChange() const
return staff()->currentKeyTick(keyTick) == keyTick;
}

bool KeySig::isFirstSystemKeySig()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we should make this function static and remove it from this class (perhaps declare it inside utils.h or directly in transpose.cpp). We are trying to make the implementation of engraving items as simple as possible (so they won't implicitly use systems/measures/etc)

@miiizen miiizen changed the title Fix #18404: Transpose tool will only transpose initial key signature … Transpose tool will only transpose initial key signature … Oct 23, 2023
Copy link
Contributor

@cbjeukendrup cbjeukendrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some code review fixes (some unnecessary includes); if you're happy with those, I think it can be merged.

src/engraving/dom/utils.cpp Show resolved Hide resolved
@miiizen
Copy link
Contributor Author

miiizen commented Oct 30, 2023

@cbjeukendrup looks good to me!

@cbjeukendrup cbjeukendrup merged commit a2d9be1 into musescore:master Oct 30, 2023
11 checks passed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Oct 31, 2023
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Oct 31, 2023
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Oct 31, 2023
@miiizen miiizen deleted the 18404-transpose-key-sig branch January 9, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transpose action adds new key signature, if selection starts at begining of system
4 participants