-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transpose tool will only transpose initial key signature … #18530
Transpose tool will only transpose initial key signature … #18530
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
…e on a system if there is a key change Backport of musescore#18530
…e on a system if there is a key change Backport of musescore#18530
165d29c
to
3a56014
Compare
src/engraving/dom/keysig.cpp
Outdated
@@ -156,6 +157,15 @@ bool KeySig::isChange() const | |||
return staff()->currentKeyTick(keyTick) == keyTick; | |||
} | |||
|
|||
bool KeySig::isFirstSystemKeySig() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, we should make this function static and remove it from this class (perhaps declare it inside utils.h or directly in transpose.cpp). We are trying to make the implementation of engraving items as simple as possible (so they won't implicitly use systems/measures/etc)
f1d2858
to
803e646
Compare
…ignature on a system if there is a key change
803e646
to
341efb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed some code review fixes (some unnecessary includes); if you're happy with those, I think it can be merged.
@cbjeukendrup looks good to me! |
…e on a system if there is a key change Backport of musescore#18530
…e on a system if there is a key change Backport of musescore#18530
…e on a system if there is a key change Backport of musescore#18530
…on a system if there is a key
If the first key signature on a system is a change to the measure before, it will be transposed. Otherwise it will be left untouched.
Resolves: #18404