Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FluidSynth from 2.1.4 to 2.3.3 #18790

Merged
merged 5 commits into from
Jul 25, 2023
Merged

Update FluidSynth from 2.1.4 to 2.3.3 #18790

merged 5 commits into from
Jul 25, 2023

Conversation

cbjeukendrup
Copy link
Contributor

@cbjeukendrup cbjeukendrup commented Jul 24, 2023 •
edited

Resolves: #18123
Resolves: #17518
(Hopefully)

The idea is simple:

  1. Replace our FluidSynth folder with the unmodified 2.1.4, to revert all our patches; commit that
  2. Perform the update; commit that
  3. Revert the commit that reverted the patches, i.e. re-apply them (only solving the conflicts was a bit tough)
  4. Make additional fixes and updates to the surrounding code

@igorkorsukov igorkorsukov merged commit 63c1452 into musescore:master Jul 25, 2023
11 checks passed
@cbjeukendrup cbjeukendrup deleted the update_fluid branch July 25, 2023 16:06
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Jul 31, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorkorsukov igorkorsukov igorkorsukov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cbjeukendrup @igorkorsukov