Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #19063 missing init key sig after removing first measure + cleanup #19090

Merged

Conversation

sammik
Copy link
Contributor

@sammik sammik commented Aug 18, 2023

Resolves: #19063

newly created element needs to have parent element (segment) set

+ little cleanup

  • dont add key signatures to use atonal keysig for drum staves
  • add correct key signature to each staff individually (necessary, if some of staves contains local key signature)
  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@sammik
Copy link
Contributor Author

sammik commented Aug 21, 2023

@mike-spa

@RomanPudashkin RomanPudashkin merged commit 23c6b2c into musescore:master Aug 31, 2023
11 checks passed
@sammik sammik deleted the missing-initial-keysig-removed-measure branch August 31, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key signature is lost when removing first measure
4 participants