Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default settings for MusicXML import #19214

Merged

Conversation

cbjeukendrup
Copy link
Contributor

Resolves: #17828

Regarding that mysterious misplaced m_configuration->init() call:

  • in 025baf6, where it was created, it was in the correct place
  • in b2ff7d6, it was accidentally moved to resolveImports, along with some things that do belong in resolveImports

@cbjeukendrup cbjeukendrup force-pushed the musicxml_import_default_settings branch from 0e4c1d9 to fbc108e Compare August 29, 2023 15:36
@DmitryArefiev
Copy link
Contributor

Tested #17828 on Win10, Mac13, LinuxUbuntu 22.04 - FIXED

@DmitryArefiev DmitryArefiev merged commit e3751ee into musescore:master Aug 30, 2023
11 checks passed
@cbjeukendrup cbjeukendrup deleted the musicxml_import_default_settings branch August 30, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MusicXML Imports settings in Preferences should have the same default state as in MS3
3 participants