Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MusicXML Imports settings in Preferences should have the same default state as in MS3 #17828

Closed
DmitryArefiev opened this issue Jun 2, 2023 · 9 comments · Fixed by #19214
Closed

MusicXML Imports settings in Preferences should have the same default state as in MS3 #17828

DmitryArefiev opened this issue Jun 2, 2023 · 9 comments · Fixed by #19214
Assignees
@cbjeukendrup
Labels
MusicXML P1 Priority: High regression MS3 Regression from MS3 (3.6.2)

Comments

@DmitryArefiev
Copy link
Contributor

DmitryArefiev commented Jun 2, 2023 •
edited
Loading

Issue type

MusicXML import

Steps to reproduce

See MS3 settings
Capture

and see the default state in MS4 #17828 (comment)

Screenshots/Screen recordings

Because of that default settings MusicXML import looks like this:

bandicam.2023-06-02.15-35-29-064.mp4

MuseScore Version

4.1

Regression

Yes, this used to work in MuseScore 3.x and now is broken

Operating system

Windows10
@muse-bot muse-bot added needs review The issue needs review to set priority, fix version or change status etc. regression MS3 Regression from MS3 (3.6.2) labels Jun 2, 2023
@DmitryArefiev DmitryArefiev removed the needs review The issue needs review to set priority, fix version or change status etc. label Jun 2, 2023
@muse-bot muse-bot assigned bkunda and DmitryArefiev and unassigned bkunda and DmitryArefiev Jun 2, 2023
@DmitryArefiev DmitryArefiev added the P1 Priority: High label Jun 2, 2023
@DmitryArefiev DmitryArefiev added P0 Priority: Critical and removed P1 Priority: High labels Jun 2, 2023
@oktophonie
Copy link
Contributor

Not really a bug; the option for this is now turned off by default for some reason (Edit > Preferences):
image

So this can easily be addressed by having that turned on by default, if that's preferred.

@DmitryArefiev
Copy link
Contributor Author

Ahhh.. Good catch! Thanks for investigation :)

I'll rewrite the bug

@DmitryArefiev DmitryArefiev changed the title System breaks don't import from MusicXML file MusicXML Imports settings in Preferences should have the same default state as in MS3 Jun 2, 2023
@DmitryArefiev DmitryArefiev added P1 Priority: High and removed P0 Priority: Critical labels Jun 2, 2023
@cbjeukendrup cbjeukendrup added the good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute label Jun 2, 2023
@DmitryArefiev
Copy link
Contributor Author

@HemantAntony Maybe you can look into this when have a time? :)

@Jojo-Schmitz

This comment was marked as resolved.

Sign in to view
@DmitryArefiev

This comment was marked as resolved.

Sign in to view
@Jojo-Schmitz

This comment was marked as resolved.

Sign in to view
HemantAntony added a commit to HemantAntony/MuseScore that referenced this issue Jun 10, 2023
@HemantAntony
Fix musescore#17828: MusicXML default settings do not work
714088c
@HemantAntony HemantAntony mentioned this issue Jun 10, 2023
Closed
8 tasks
@HemantAntony
Copy link
Contributor

@DmitryArefiev Yeah, I made a PR! - #17925

@DmitryArefiev
Copy link
Contributor Author

@HemantAntony Cool. Thanks! I'll test it after successful CR

@cbjeukendrup cbjeukendrup mentioned this issue Aug 29, 2023
Merged
@cbjeukendrup cbjeukendrup removed the good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute label Aug 29, 2023
@DmitryArefiev
Copy link
Contributor Author

Fixed in #19214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbjeukendrup cbjeukendrup

Labels
MusicXML P1 Priority: High regression MS3 Regression from MS3 (3.6.2)
Projects
MuseScore 4.2
Status: Done
Milestone
No milestone
8 participants
@Jojo-Schmitz @Eism @muse-bot @oktophonie @cbjeukendrup @bkunda @HemantAntony @DmitryArefiev