Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: Measure Repeats -> Measure repeats and more #19341

Merged
merged 2 commits into from
Sep 9, 2023
Merged

Fixes: Measure Repeats -> Measure repeats and more #19341

merged 2 commits into from
Sep 9, 2023

Conversation

Gootector
Copy link
Contributor

Fixes:
Measure Repeats -> Measure repeats
Articulations, Ornaments -> Articulations, ornaments
Automatic Capitalization -> Automatic capitalization
like #19155.

Greetings,
Gootector

Resolves: #NNNNN

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

Grzegorz Pruchniakowski added 2 commits September 9, 2023 06:48
Fixes:
Measure Repeats -> Measure repeats
Articulations, Ornaments -> Articulations, ornaments
Automatic Capitalization -> Automatic capitalization
like #19155.

Greetings,
Gootector
Fix:
Replace Instrument… -> Replace instrument…
like #19155.

Greetings,
Gootector
@Jojo-Schmitz
Copy link
Contributor

Umph, why did I miss those?

@cbjeukendrup
Copy link
Contributor

By the way, for information, we are planning to upload all new strings and your fixes to Transifex at the end of this month. Currently, Transifex is still bound to 4.1.x, so that new translations will go to 4.1.x's "Check for language updates" button. By the end of this month, we'll switch it over to 4.2, so that we can push the new changes.

@cbjeukendrup cbjeukendrup merged commit 1aaf253 into musescore:master Sep 9, 2023
11 checks passed
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Sep 9, 2023

If you'd drop the -no-obsolete, the updated strings and their translations would work even for 4.1, the old strings would stay untouched untouched and the new would be available to 4.2 only.

IMHO the use of -no-obsolete should be the exception rather than the rule, only on major version changes. It was handled that way in the past (Mu1,2,3)

@Gootector Gootector deleted the patch-1 branch September 10, 2023 05:46
@Gootector
Copy link
Contributor Author

@cbjeukendrup Thanks for info and merge.
@Jojo-Schmitz Don't worry - you're only human. There is always something missing, if you make changes manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants